Commit Graph

3007 Commits

Author SHA1 Message Date
Love Hörnquist Åstrand
9be36e4522 (krb5_addlog_dest): free fn in case of error
Coverity, NetBSD CID#1882


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17038 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 09:41:26 +00:00
Love Hörnquist Åstrand
7b91fa46c7 Fix deref before NULL check, fix error handling.
Coverity, NetBSD CID#2369


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17037 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 09:33:15 +00:00
Love Hörnquist Åstrand
494ca3d6a8 (krb5_get_forwarded_creds): in_creds->client should always be set, assume so.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17036 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 09:28:15 +00:00
Love Hörnquist Åstrand
db048d96d6 (any_next_entry): restructure to make it easier to read
Fixes Coverity, NetBSD CID#625


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17035 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 09:20:13 +00:00
Love Hörnquist Åstrand
2a7b485275 (krb5_string_to_key_derived): deref after NULL check.
Coverity NetBSD CID#2367


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17034 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 08:58:53 +00:00
Love Hörnquist Åstrand
6b9e922298 (krb5_build_authenticator): use calloc. removed check that was never
really used. Coverity NetBSD CID#2370


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17033 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 08:53:21 +00:00
Love Hörnquist Åstrand
59aa089d03 (krb5_verify_ap_req2): make sure `ticket´ points to NULL in case of
error, add error handling, use calloc.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17025 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-09 17:56:10 +00:00
Love Hörnquist Åstrand
4466bd867f (krb5_ret_principal): fix memory leak
Coverity, NetBSD CID#1695


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17018 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-07 22:23:20 +00:00
Love Hörnquist Åstrand
5a761c7f96 (krb5_kt_ret_principal): plug a memory leak
Coverity NetBSD CID#1890


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17013 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-07 21:57:31 +00:00
Love Hörnquist Åstrand
d9b82bea73 fix spelling
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16958 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 10:32:20 +00:00
Love Hörnquist Åstrand
c1ce715df2 (send_and_recv_http): don't expose freed pointer, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16957 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 02:32:03 +00:00
Love Hörnquist Åstrand
529acecb2b (krb5_rd_cred): don't expose freed pointer, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16956 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 02:27:33 +00:00
Love Hörnquist Åstrand
03f05a7a6e (krb5_make_addrport): clear return value on error, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16955 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 02:17:31 +00:00
Love Hörnquist Åstrand
3dfde09cb0 Avoid using free memory, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16946 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:39:54 +00:00
Love Hörnquist Åstrand
c857bdbb07 (expand_realm): avoid passing NULL to strlen, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16945 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:36:45 +00:00
Love Hörnquist Åstrand
1305bbe9d5 (krb5_rd_cred): avoid a memory leak on malloc failure, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16944 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:31:10 +00:00
Love Hörnquist Åstrand
d579ee0dc9 (_krb5_krbhost_info_move): replace a strcpy with a memcpy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16943 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:28:42 +00:00
Love Hörnquist Åstrand
4fd7055bdf (get_cell_and_realm): plug a memory leak, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16942 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:24:52 +00:00
Love Hörnquist Åstrand
4b2323bd43 (fkt_next_entry_int): remove a dereferencing NULL pointer, found by
IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16941 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:22:33 +00:00
Love Hörnquist Åstrand
fd1ea1cc54 (init_creds_init_as_req): in AS-REQ the cname must always be given,
don't avoid that fact and remove a cname == NULL case. Plugs a memory
leak found by IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16940 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:20:15 +00:00
Love Hörnquist Åstrand
0c29fd2ed1 (default_s2k_func): avoid exposing free-ed memory on error. Found by
IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16939 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:10:35 +00:00
Love Hörnquist Åstrand
3abd33be22 (_krb5_get_init_creds_opt_copy): use calloc to avoid uninitialized
memory problem.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16938 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:08:30 +00:00
Love Hörnquist Åstrand
6d5788be42 (krb5_copy_data): avoid exposing free-ed memory on error. Found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16937 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:06:07 +00:00
Love Hörnquist Åstrand
a699632a9e (fcc_gen_new): fix a use after free, found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16936 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 01:04:37 +00:00
Love Hörnquist Åstrand
4676501833 (krb5_config_vget_strings): IBM checker thought it found a memory
leak, it didn't, but there was another error in the code, lets fix
that instead.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16935 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 00:59:19 +00:00
Love Hörnquist Åstrand
657fc04cb0 (_krb5_expand_default_cc_name): plug memory leak. Found by IBM checker.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16934 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 00:54:48 +00:00
Love Hörnquist Åstrand
5ac7ec3e3e (_krb5_expand_default_cc_name): avoid return pointer to freed memory
in the error case. Found by IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16932 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 00:52:26 +00:00
Love Hörnquist Åstrand
1708cc306c (krb5_addlog_dest): make string length match strings in strcasecmp.
Found by IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16928 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 00:22:08 +00:00
Love Hörnquist Åstrand
ff8a601d49 (krb5_get_init_creds_opt_set_pkinit); fix prototype
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16857 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-30 03:36:32 +00:00
Love Hörnquist Åstrand
945efb8a96 Add pool of certificates to help certificate path building for clients
sending incomplete path in the signedData.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16854 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-28 19:57:25 +00:00
Love Hörnquist Åstrand
cd6acf1200 Allow passing in related certificates used to build the chain.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16850 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-28 04:38:14 +00:00
Love Hörnquist Åstrand
d275b39ee1 Use ticket flags definition, might fix Mac OS X Kerberos.app problems.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16825 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-27 04:22:23 +00:00
Love Hörnquist Åstrand
74691a77af Add ticket flags definitions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16824 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-27 04:21:06 +00:00
Love Hörnquist Åstrand
5e82b46be0 Use less openssl, spell chelling.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16823 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-27 04:12:34 +00:00
Love Hörnquist Åstrand
d5ecf2d794 Add libhx509.la when PKINIT is used.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16816 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-27 00:05:29 +00:00
Love Hörnquist Åstrand
f024392e81 Switch to hx509.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-26 23:55:17 +00:00
Love Hörnquist Åstrand
a603f569c3 (_krb5_pk_rd_pa_reply): pass down the req_buffer in the w2k case
too. From Douglas E. Engert.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16801 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-23 17:19:14 +00:00
Love Hörnquist Åstrand
5a9da5632c (_krb5_mk_req_internal): Indent and remove unused code block.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16798 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-19 20:33:13 +00:00
Love Hörnquist Åstrand
4740e4a03a (_krb5_mk_req_internal): on failure, goto error handling.
Fixes Coverity NetBSD CID 2591 by catching a failing krb5_copy_keyblock()


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16797 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-19 20:30:34 +00:00
Love Hörnquist Åstrand
4e8e0a32a2 (krb5_rd_priv): reset outdata before returning error or success
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16796 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-18 22:15:57 +00:00
Love Hörnquist Åstrand
ddaa580f35 (krb5_rd_safe): reset outdata before returning error or success
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16795 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-18 22:15:28 +00:00
Love Hörnquist Åstrand
544071b438 (krb5_read_message): reset out data before return error or success,
fixes many Coverity bugs.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16794 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-18 22:13:45 +00:00
Love Hörnquist Åstrand
08687cb067 (krb5_free_addresses): reset val,len in address when free-ing.
Fixes Coverity NetBSD bug #2605
(krb5_parse_address): reset val,len before possibly return errors
Fixes Coverity NetBSD bug #2605


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16793 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-17 22:12:13 +00:00
Love Hörnquist Åstrand
e1bd6f1007 (recv_loop): it should never happen, but make sure nbytes > 0
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16789 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-07 19:39:59 +00:00
Love Hörnquist Åstrand
ac1c623242 (add_addrs): handle the case where addr->len == 0 and n == 0, then
realloc might return NULL.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16788 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-07 19:38:09 +00:00
Love Hörnquist Åstrand
203072d917 (decrypt_*): handle the case where the plaintext is 0 bytes long,
realloc might then return NULL.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16787 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-07 19:34:55 +00:00
Love Hörnquist Åstrand
5cca9c04e6 Drop krb5_string_to_key_derived.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16783 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-02-28 15:02:37 +00:00
Love Hörnquist Åstrand
b9b27743b2 Remove krb5_string_to_key_derived.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16782 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-02-28 15:01:22 +00:00
Love Hörnquist Åstrand
d86be025ae (AES_string_to_key): drop _krb5_PKCS5_PBKDF2 and use PKCS5_PBKDF2_HMAC_SHA1
instead.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16781 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-02-28 14:52:57 +00:00
Love Hörnquist Åstrand
cbd4c81a98 reformat, avoid free-ing un-init'd memory
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16780 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-02-28 14:51:39 +00:00