oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,373 Commits 2 Branches 2 Tags
8fa446d75c2076d8ba607b09268e976803c6d44a
Commit Graph

29 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
27b314c4e7 %o is unsigned int, case appropriately 2009-08-14 11:17:44 +02:00
Love Hörnquist Åstrand
1e5a14f8bd use S_ISDIR and S_ISREG 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25229 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-25 23:44:52 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
85c940fa73 Sync with NetBSD rcp, add v6 parsing support and no setuid code at all. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23028 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-04-17 17:30:06 +00:00
Love Hörnquist Åstrand
847a99a0ec Check return values from setuid, prompted by MIT 
advisory.  Thanks to Tom Yu at MIT, and Michael Calmer and Marcus
Meissner at SUSE.  Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17878 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-08-08 21:43:58 +00:00
Love Hörnquist Åstrand
f1e2dae0f6 Check return values from seteuid, prompted by MIT advisory. 
Thanks to Tom Yu at MIT, and Michael Calmer and Marcus Meissner at SUSE.
Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17874 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-08-08 21:08:46 +00:00
Love Hörnquist Åstrand
e5dc0153d3 Check return value from asprintf instead of string != NULL since it 
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16218 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-10-22 14:18:19 +00:00
Love Hörnquist Åstrand
60ed51e6da MODEMASK is defined in sys/vnode.h on Solaris, so undef it before we 
define our own.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15123 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-11 11:04:30 +00:00
Johan Danielsson
558712f71f add -e (passed to rsh) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13849 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-05-14 14:33:42 +00:00
Johan Danielsson
6ecd034eaf add a -4 option 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12023 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 12:14:45 +00:00
Johan Danielsson
c884ea3911 more va_* fixing; from Thomas Klausner 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10738 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-09-24 12:14:12 +00:00
Assar Westerlund
3fbcb739f8 (run_err): always match va_start and va_end 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10672 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-09-08 01:53:37 +00:00
Assar Westerlund
897f0b1f93 unsigned char casts for is*, casts for socket functi, add headers 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10646 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-09-03 05:54:18 +00:00
Assar Westerlund
95b8dde3e4 (main): add missing setprogname 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10350 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-07-19 13:57:36 +00:00
Assar Westerlund
81ed451753 some cleanup 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10047 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-06-14 20:30:25 +00:00
Assar Westerlund
8ced53f487 add some const 
replace a few malloc/snprintf with asprintf


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10046 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-06-14 20:28:34 +00:00
Assar Westerlund
4da20225ee (sizestr): remove and use snprintf to do this correctly instead 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10044 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-06-14 20:14:21 +00:00
Johan Danielsson
396aa1eb2a convert to use getarg 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9798 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-04-21 16:03:10 +00:00
Johan Danielsson
19a4a3c9c4 do a better job of supporting files larger than 2GB 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9796 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-04-21 15:31:46 +00:00
Assar Westerlund
16732f1b66 add -F for forwarding ticket, from Ake Sandgren <ake@cs.umu.se> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9652 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-07 06:28:54 +00:00
Assar Westerlund
87e548e8fc remove non-STDC code 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9583 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-29 22:47:55 +00:00
Assar Westerlund
249225774c no calls to err with NULL 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9558 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-29 02:05:55 +00:00
Assar Westerlund
9f46cf0a61 use rcp_locl.h 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9550 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-28 22:52:38 +00:00
Assar Westerlund
43c22e0a0a remove unused include files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9534 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-28 14:31:46 +00:00
Assar Westerlund
cba14b853b add RCSID 
S_ISTXT -> S_ISVTX
printf sizes of files with %lu instead of %q (which is not portable)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9528 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-27 20:11:18 +00:00
Assar Westerlund
bbf9b61001 remove __P, use st_mtime et al from struct stat 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9526 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-27 20:04:25 +00:00
Assar Westerlund
6cf377153d add port of bsd rcp changed to use existing rsh, contributed by Richard Nyberg <rnyberg@it.su.se> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9520 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-27 18:36:21 +00:00