oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
30,226 Commits 2 Branches 2 Tags
8836e6a39d6c6e3e77d780ac6c9789e65a7f8649
Commit Graph

31 Commits

Author SHA1 Message Date
Jeffrey Altman
9c27eaa079 lib/krb5: krb5_rc_store always fclose(f) 
Change-Id: Ibc4864e97e6ada0ef09b0610669eabb1a52f896e
 2022-01-16 19:37:44 -05:00
Nicolas Williams
5f63215d0d Always perform == or != operation on cmp function result 
Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.

This change converts all use of cmp function usage from

```
    if (strcmp(a, b) || !strcmp(c, d)) ...
```

to

```
    if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```

for all C library cmp functions and related:

 - strcmp(), strncmp()
 - strcasecmp(), strncasecmp()
 - stricmp(), strnicmp()
 - memcmp()

Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188
 2021-11-24 22:30:44 -05:00
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Love Hornquist Astrand
237ac68bb0 don't write out stack data in reply file 2012-11-27 21:58:06 -08:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
788189805c catch error from as.*printf 2010-05-30 13:28:49 -07:00
Love Hornquist Astrand
687db64c56 Patch from Secure Endpoints/Asanka Herath for windows support 2009-12-21 08:45:28 +01:00
Love Hornquist Astrand
75aa4b44fa switch to rk_strerror_r 2009-12-13 11:42:12 -08:00
Love Hornquist Astrand
bf01a8461f Use strerror_r 2009-10-12 09:06:11 -07:00
Love Hornquist Astrand
2a17be87ab Remove direct use of MD5 2009-08-10 09:06:50 +02:00
Love Hörnquist Åstrand
942a821fab remove RCSID 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
dda674cdac N_()ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23800 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-07 21:35:03 +00:00
Love Hörnquist Åstrand
1e91bb390c close-on-exec 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23467 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-27 12:16:37 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
b2e2e00900 use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23307 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 03:30:25 +00:00
Love Hörnquist Åstrand
7452077a9f (krb5_rc_resolve_full): make compile 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17047 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-10 17:13:49 +00:00
Love Hörnquist Åstrand
c5dd980dba (krb5_rc_resolve_full): don't return pointer to a allocated 
krb5_rcache in case of error.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17039 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-10 09:48:42 +00:00
Love Hörnquist Åstrand
91351971f7 add KRB5_LIB_FUNCTION to all exported functions 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13863 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-05-25 21:46:46 +00:00
Assar Westerlund
013de43918 (krb5_get_server_rcache): cast argument to printf 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10279 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-07-03 19:33:13 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-14 06:14:52 +00:00
Assar Westerlund
59a594bad4 use the openssl api for md4/md5/sha. handle openssl/*.h 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9559 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-29 02:09:01 +00:00
Johan Danielsson
8881626dd9 fix query-replace-o from MD5 API change, and the struct is called 
krb5_donot_replay


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9383 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-13 22:40:57 +00:00
Johan Danielsson
9fc7fc0aad implement krb5_get_server_rcache 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9288 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-06 21:00:55 +00:00
Johan Danielsson
ff3d751327 rcsid 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9137 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-11-05 16:46:15 +00:00
Assar Westerlund
38ef6e56ea (checksum_authenticator): update to new API for md5 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7858 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-02-06 05:21:21 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Johan Danielsson
a79c7e9a2c Replay cache. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4037 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-11-17 21:35:12 +00:00