Commit Graph

34 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hörnquist Åstrand
67612f57da fix warning
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24571 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-04 22:02:57 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
fe5323f0e5 use unsigned/size_t where approprite
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22895 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:52:20 +00:00
Love Hörnquist Åstrand
44c8c17c29 make writenet take const void * and size_t, abort if size it too large
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15844 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:36:16 +00:00
Johan Danielsson
60fe67f93b (putf): %t: the regular and streamspty case are functionally
equivalent, so merge them, this also makes it work better on machines
that puts their devices in a subdirectory to /dev


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15003 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-28 16:36:32 +00:00
Assar Westerlund
897f0b1f93 unsigned char casts for is*, casts for socket functi, add headers
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10646 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-03 05:54:18 +00:00
Assar Westerlund
a4190c9469 remove two warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10353 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-07-19 15:58:01 +00:00
Assar Westerlund
29b83d65a0 no return <void value> in a void function
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9981 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-05-17 00:34:42 +00:00
Assar Westerlund
56cb680b45 (fatalperror_errno): add a new function with explicit errno parameter
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9802 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-04-24 23:11:05 +00:00
Assar Westerlund
265ace2a58 (stilloob): check that fds are not too large to select on
(ttloop): remove confusing output of errno


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9107 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-10-08 13:34:27 +00:00
Assar Westerlund
bf75fac82a large strc{py,at}_truncate -> strlc{py,at} replacement
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6984 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-16 20:41:57 +00:00
Assar Westerlund
70daae2bd7 (ttloop): make it return 1 if interrupted by a signal, which must have
been what was meant from the beginning


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6900 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-05 19:16:53 +00:00
Assar Westerlund
e9fea047b0 random fixes to make it build with socks
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5028 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-06-13 00:06:56 +00:00
Johan Danielsson
a5f54865d4 merge strcpy_truncate branch
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5027 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-06-09 19:25:40 +00:00
Assar Westerlund
770632d951 const and char-cleanup
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3694 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-10-29 01:27:11 +00:00
Assar Westerlund
fc1918e7e4 const-ize fatalperror
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2183 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-12 14:38:09 +00:00
Assar Westerlund
5da8f7da41 telnetd cleanup
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1695 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-11 06:30:05 +00:00
Assar Westerlund
dd02a92a8b replace sprintf all over the place
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1635 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-02 14:29:33 +00:00
Assar Westerlund
6202f22614 removed all stupid (void)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1034 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 20:23:48 +00:00
Assar Westerlund
239db0f710 removed all stupid register declarations
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1033 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 20:04:43 +00:00
Assar Westerlund
edb66c9354 SOCKS-support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@860 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-18 05:35:32 +00:00
Johan Danielsson
f82b0c90ac Fix auth name bug.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@523 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-05-12 18:36:52 +00:00
Björn Groenvall
bd174d9fe5 Minor changes for HP compiler, some cleanup
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@340 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-03-27 11:42:44 +00:00
Assar Westerlund
7d6614971d fix args for printsub
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@242 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-10 11:49:57 +00:00
Unknown User d91-jda
ac65f7b044 Protoized some more.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@241 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-09 23:52:00 +00:00
Assar Westerlund
0b577a7b69 ...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@230 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-04 16:14:07 +00:00
Unknown User d91-jda
5a9fea2fe9 *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@221 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-04 05:56:09 +00:00
Unknown User d91-jda
e6b50696c6 *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@216 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-01-30 15:50:36 +00:00
Björn Groenvall
67f906f599 Added RCSID("$Id$");
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@206 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-12-27 13:25:39 +00:00
Unknown User d91-jda
a445da10c5 More ANSI/ISO 9899-1990 to the people!
Now actually builds (not including util) with DEC "cc -std1" and Sun
"acc -Xc".  There are still major prototype conflicts, but there isn't
much to do about this.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@192 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-11-12 20:22:06 +00:00
Unknown User d91-jda
e555b42b4a Added support for autoconf
The following rules apply to the initial banner message printed by telnetd:

if libc contains cgetent and the "default" entry in /etc/gettytab
defines an im - use that.

else if configured with a specific default im (--enable-default-im) use that

else use a sensible default "systemname os-release (hostname) (ttyname)"

The im can now contain these vaiables:

%s - system name (uname -s)
%r - system release (uname -r)
%v - system version (uname -v)
%m - machine (uname -m)
%h - hostname
%t - tty
%d - date

Default for Cray is "Cray UNICOS (%h) (%t)",  (this should probably change)
 for AIX: "%s %v.%r (%h) (%t)"
 and for everything else: "%s %r (%h) (%t)".

These defaults are defined in ext.h

If the system does not have uname(2), %s defaults to "Unix"
 and %r, %v and %m to the-empty-string.

Is this clear enough?


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@59 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-07-20 00:02:52 +00:00
Unknown User d91-jda
ebd0b9fa73 Initial revision
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@52 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-07-19 18:57:49 +00:00