Commit Graph

22 Commits

Author SHA1 Message Date
Luke Howard 071b95e683 roken: fix theoretical leak introduced in 7fbe7be6
split_spec() should free output parameters if it fails. This was not a leak in
practice because its single caller cleaned up anyway, but cleaning up for good
hygiene.
2021-09-23 10:32:45 +10:00
Luke Howard 7fbe7be675 roken: check strdup succeeds in roken_gethostby_setup()
Closes: #824
2021-09-20 17:58:19 +10:00
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand 0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Love Hornquist Astrand 9773655027 catch error from as.*printf 2010-05-30 12:41:06 -07:00
Asanka Herath d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hörnquist Åstrand 0d31d3d686 drop rcsid
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24356 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:30:37 +00:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand fea34a948f Set proxy port to 0 to unconfuse BEAM.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21157 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-18 22:03:13 +00:00
Love Hörnquist Åstrand 5cd0815781 use "roken.h" consitantly
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21005 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:54:35 +00:00
Love Hörnquist Åstrand 9df9f6a9da revert 21003
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21004 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:53:10 +00:00
Love Hörnquist Åstrand 12df8538af use "roken.h" consitantly
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21003 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:42:05 +00:00
Love Hörnquist Åstrand fcfcfa06cb (roken_gethostby): make addr_list one larger to avoid a off-by-one
error. Found by IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16926 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-02 00:09:28 +00:00
Love Hörnquist Åstrand 709aa58c74 define ROKEN_LIB_FUNCTION on all exported functions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14773 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-12 11:29:18 +00:00
Love Hörnquist Åstrand bac06ed5bd (roken_gethostby): s/sin/addr/ to avoid shadowing
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14698 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-03-30 16:50:02 +00:00
Assar Westerlund e7dc9ac29e remove netdb.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7542 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-05 13:18:55 +00:00
Johan Danielsson 3ca5f8150f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 16:58:55 +00:00
Assar Westerlund 3988f113a2 (roken_gethostby_setup): remove unused variable
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5096 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-07-24 07:25:27 +00:00
Johan Danielsson 483b470aaa Make `roken_gethostby_setup' take url-like specification instead of
split up versions. Makes it easier for calling applications.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4556 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-03-06 02:38:10 +00:00
Johan Danielsson 101287ce54 Another miracle of the 20th century: gethostby* over HTTP.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4542 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-03-05 23:21:42 +00:00