oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
29,787 Commits 2 Branches 2 Tags
686d5116dec3d941f700deb51082b86f78687e46
Commit Graph

32 Commits

Author SHA1 Message Date
Jeffrey Altman
387684aa93 WIN32: fix calling conventions for 32-bit builds 
On 32-bit Windows Intel builds the __cdecl and __stdcall calling
conventions are different so labeling the functions that are
exported or assigned to function pointers matters.

Change-Id: I03b6f34baeb9ffb2e683fd979f12f27a5078a4da
 2019-01-14 06:12:36 -05:00
Nicolas Williams
620862049e Use roken_get_*() instead of getpwuuid() 
Using non-reentrant getpwuid() (or getpwnam(), or getspnam())  can be
dangerous.  We had a report of a login application / PAM that calls
those, and Heimdal, by calling them too, clobbered the cached struct
passwd used by the login app / PAM.
 2018-12-25 22:11:19 -06:00
Nicolas Williams
7dfad1ab0b Use secure_getenv() instead of issuid() 2017-04-17 18:02:30 -04:00
Viktor Dukhovni
aad3b229ae Fix off by 1 write. 2017-03-17 11:51:30 -04:00
Nicolas Williams
3ba12317a0 Misc fixes (coverity) 2016-11-28 15:09:55 -06:00
Luke Howard
f789d8403e hx509: explicitly include ref/pkcs11.h 
review comment from Nico Williams: explicitly include ref/pkcs11.h to
avoid any conflict with system PKCS#11 header
 2015-12-09 11:03:48 +11:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Asanka Herath
dba793110b Fix unused variable on Windows for softp11.c 2010-08-20 13:03:36 -04:00
Asanka Herath
5d48156c51 Make hx509 compile on windows 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2009-11-25 00:20:44 +01:00
Love Hornquist Astrand
6e319e49e1 use hx509_certs_iter_f 2009-11-22 13:53:41 -08:00
Love Hornquist Astrand
72e306c7e3 Push cert down deaper into the stack 2009-08-21 18:34:21 -07:00
Love Hörnquist Åstrand
209dbbb1e0 use calloc 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24116 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-11 05:02:22 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
ab3d0e36c0 drop never used variable 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23663 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-08-25 02:30:50 +00:00
Love Hörnquist Åstrand
39ecfa21bd close-on-exec 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23458 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-27 12:13:12 +00:00
Love Hörnquist Åstrand
66719e3277 close-on-exec 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23455 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-27 12:12:03 +00:00
Love Hörnquist Åstrand
8328004709 call va_start before using vsnprintf. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22857 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-04-07 18:49:33 +00:00
Love Hörnquist Åstrand
0f10735602 Use unsigned char as argument to isspace(), from Michael ven Elst. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22647 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-02-25 07:35:44 +00:00
Love Hörnquist Åstrand
45b392682d Use unsigned char as argument to isspace(), from Michael ven Elst. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22646 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-02-25 07:35:04 +00:00
Love Hörnquist Åstrand
ea56b2c19d Remove un-used stuff. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22479 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-17 11:41:46 +00:00
Love Hörnquist Åstrand
7512386d17 fix comment, remove label. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22475 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-17 11:24:56 +00:00
Love Hörnquist Åstrand
1e41fab681 Add option app-fatal to control if softtoken should abort() on 
erroneous input from applications.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22470 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-17 11:13:37 +00:00
Love Hörnquist Åstrand
8b206a59cc Use HX509_CERTS_UNPROTECT_ALL when there is no pin code. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22463 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-16 14:24:33 +00:00
Love Hörnquist Åstrand
e84294788e Support PINs to login to the store. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22460 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-15 22:08:07 +00:00
Love Hörnquist Åstrand
471b5b6ea3 Drop unused stuff. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22454 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-15 20:19:50 +00:00
Love Hörnquist Åstrand
33250f5762 Add more glue to figure out what keytype this certificate is using. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22451 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-15 19:39:59 +00:00
Love Hörnquist Åstrand
b99e6ad703 Add debug. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22448 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-15 19:20:11 +00:00
Love Hörnquist Åstrand
b7bcf51d6e rename SoftToken to Heimdal hx509 SoftToken. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22439 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-14 21:07:39 +00:00
Love Hörnquist Åstrand
c9f443454e Add a PKCS11 provider supporting signing and verifing sigatures. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22435 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-14 20:53:56 +00:00