oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
28,620 Commits 2 Branches 2 Tags
63411321753e1ee959fd1e69ba5986d2438f1b39
Commit Graph

107 Commits

Author SHA1 Message Date
Viktor Dukhovni
766e6cda8a Avoid potential memory leak in krb5_sendto_set_hostname 
If the hostname was already set, a typo in a test meant we were not
freeing it.  While we're at it, handle the unlikely possibility that
the existing pointer is passed as the new value.
 2017-08-23 15:10:38 -05:00
Nicolas Williams
9609397874 Misc 64-bit time support (debug message) 
Originally by Christos Zoulas.  Originally used %jd and casts to
intmax_t, however, we can't use those on Windows yet.
 2017-03-13 18:39:41 -04:00
Nicolas Williams
6a0f45c4d7 Use __attribute__ ((__name__)) form 
Protect against macros named noreturn and so on.
 2017-03-13 18:39:41 -04:00
Nicolas Williams
3ba12317a0 Misc fixes (coverity) 2016-11-28 15:09:55 -06:00
Nicolas Williams
f38089257b Misc fixes (coverity) 2016-11-20 17:43:51 -06:00
Nicolas Williams
8cdd54c997 coverity 1164162 2015-04-19 15:04:16 -05:00
Viktor Dukhovni
93af13ca12 Undo ntohs htons nesting to avoid variable shadowing 2015-04-14 23:02:58 +00:00
Love Hörnquist Åstrand
37afa01be3 rename roken base64, fixes #107 2014-08-22 20:57:24 -07:00
Andrew Bartlett
9f392c134f heimdal: rename send and recv pointers to avoid conflict with socket wrapper 2014-03-24 23:07:52 -05:00
Jeffrey Altman
6ae305e7a4 Fix send_to_kdc for Windows sockets 
Patchset 58ff480763 calls write() and read()
on rk_socket_t objects which on Windows are SOCKETs not C RTL file
descriptors.  This patchset uses krb5_net_write() and krb5_net_read()
in place of the direct write() and read() operations.

Change-Id: I3f7d4756357d432e4e62910f9a36824eb188b6e4
 2013-09-12 12:36:39 -04:00
Jeffrey Altman
649a1f8ff3 krb5_sendto_context potentially uninitialized ret 
Change-Id: Ia1f54f90900f78f25bb6e0573f707b4d2a7f6055
 2013-09-11 01:42:16 -04:00
Jeffrey Altman
5f138a16ef libkrb5: Add missing KRB5_LIB_FUNCTION/KRB5_LIB_CALL 
KRB5_LIB_FUNCTION and KRB5_LIB_CALL are necessary even on private
functions that are exported.

Change-Id: Iccd0cfe87ff0a9d851e29890e9cb55b3ae517ce1
 2013-06-22 21:17:32 -04:00
Love Hornquist Astrand
6850c9ac5d type casting to avoid printf warning 2013-04-24 16:45:24 -07:00
Nicolas Williams
f490acc526 Winsock connect returns WSAEWOULDBLOCK... 
...instead of EINPROGRESS.  And we get to call WSAGetLasteError() too boot :(
 2013-03-18 23:15:29 -05:00
Nicolas Williams
2c4c6101f4 Fix master (lib/krb5 warnings) 2013-03-05 21:47:20 -06:00
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Love Hornquist Astrand
6020e6c5b4 make http parser not exit out early 2013-02-10 23:20:37 -08:00
Love Hornquist Astrand
9a5de87ca1 store response in right place 2013-02-10 22:50:10 -08:00
Love Hornquist Astrand
58ff480763 rewrite send to kdc to be more agressive, try kdcs in paralell and easier to configure behavior 2013-02-10 19:02:52 -08:00
Roland C. Dowdeswell
3a30f3b0d1 Windows doesn't support poll(2) or fcntl(2) so #ifdef it out in send_to_kdc.c. 2012-08-14 22:50:33 +01:00
Roland C. Dowdeswell
842ca62336 Ensure that timeouts apply to TCP socket connexions. 
Currently the Heimdal code calls connect(2) on TCP connexions to
the KDC without setting O_NONBLOCK.  This code implements a
timed_connect() function which will in the case of SOCK_STREAM
sockets put the socket into non-blocking mode prior to calling
connect and use select(2) to apply the configured timeout to connect
completion.  This does not entirely solve the problem of potential
timeouts in the code as it is still possible to block while writing
to the socket.  A proper implementation would also likely start
new connexions after a short interval before timing out existing
connexions and return the results from the first KDC which successfully
responds but we did not do that yet.

This patch is from heimdal-1-5-branch patches:

	5b55e4429caed27b32aac4bc5930f2672a43f273
	6b66321b271ee4672e70ad349ec796dd755cf897
	2e12c7f3e8dca7e1696ebd92199617ce413565e7

Squashed together along with a quick shadowed variable warning fix
to allow it to compile with --enable-developer.
 2012-07-12 01:00:23 +01:00
Roland C. Dowdeswell
abdde6a608 Additional changes to make -Wshadow build on Ubuntu 10.04. 
Looks like they defined basename() in string.h and ntohs/htonl are
implemented in terms of __bswap16() which is a macro with tmp
variables and so one cannot embed one call to ntohs/htons in another.
Not good but we workaround this limitation in glibc.
 2012-06-07 16:59:01 +01:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hornquist Astrand
077357c848 catch error from as.*printf 2010-05-30 13:37:07 -07:00
Love Hornquist Astrand
deee0bbad9 put SOCK_CLOEXEC in the right argument, from Harald Barth 2010-01-25 23:01:09 -08:00
Love Hornquist Astrand
4182a61eba rename closesocket to rk_closesocket 2009-12-22 09:03:05 +01:00
Love Hornquist Astrand
d1d0de730d refix socket wrappers with rk_ 2009-12-21 08:50:46 +01:00
Love Hornquist Astrand
687db64c56 Patch from Secure Endpoints/Asanka Herath for windows support 2009-12-21 08:45:28 +01:00
Love Hornquist Astrand
9120d17eb0 Tell some what servers we tried to talk to 2009-09-07 20:55:05 -07:00
Love Hörnquist Åstrand
942a821fab remove RCSID 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
03e7b2d3a5 add timeout to krb5_send_to_kdc_func, from metze 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24969 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-03-27 15:01:47 +00:00
Love Hörnquist Åstrand
f9e2c569f9 make _krb5_copy_send_to_kdc_func handle no set functions 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23927 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-18 21:16:03 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
e8dd9bcc6f add helper function _krb5_copy_send_to_kdc_func 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23910 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-14 02:55:25 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
e3826c3a28 N_()ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23802 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-07 21:35:44 +00:00
Love Hörnquist Åstrand
4384fb0209 use SOCK_CLOEXEC 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23517 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-08-11 10:01:38 +00:00
Love Hörnquist Åstrand
d6c66ef961 close-on-exec 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23448 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-27 12:09:22 +00:00
Love Hörnquist Åstrand
68f4fc8b53 Add support for the send_to_kdc plugin interface. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23356 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-15 11:23:58 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
743ccd85cf make work with cpp again, reported by Hai Zaar 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21934 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-08-27 14:21:04 +00:00
Love Hörnquist Åstrand
055dd97483 (_krb5_kdc_retry): check if the whole process needs to restart or just 
skip this KDC.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21062 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-12 17:58:57 +00:00
Love Hörnquist Åstrand
e86b58e01c Add hooks for processing the reply from the server. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21058 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-12 17:49:37 +00:00
Love Hörnquist Åstrand
b965dacaf9 (krb5_sendto): zero out receive buffer. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19973 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-17 17:19:52 +00:00
Love Hörnquist Åstrand
ebc9adecfb Rename krb5_set_send_recv_func to krb5_set_send_to_kdc_func. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18679 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-20 18:42:01 +00:00
Love Hörnquist Åstrand
09dda4824a Add sent_to_kdc hook, from Andrew Bartlet. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18671 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-20 18:14:35 +00:00
Love Hörnquist Åstrand
c1ce715df2 (send_and_recv_http): don't expose freed pointer, found by IBM checker. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16957 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-02 02:32:03 +00:00