Commit Graph

475 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
308d15615e drop krb4 2011-08-10 09:27:14 -07:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hörnquist Åstrand
09b07e9ef4 fix ifdef 2011-06-19 10:58:50 -07:00
Love Hörnquist Åstrand
625d29fc3e remove unused ifdef 2011-06-19 10:58:35 -07:00
Love Hörnquist Åstrand
749c112c31 only set IP_TOS on IPv4 sockets 2011-06-19 10:58:22 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
db8e287e41 Use "Fl Fl" for long options.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:14 -07:00
Luke Howard
1a8bb5143c compile fix 2011-04-08 12:19:25 +10:00
Luke Howard
84f5aebc10 use gss_userok 2011-03-20 20:50:19 +11:00
Joerg Pulz
6f5b42957e add some more #ifdefs to compile on utmpx only systems
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2010-10-31 00:38:41 -07:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
11024751a5 make compile 2009-07-30 14:25:12 +02:00
Love Hornquist Astrand
3c053a2e09 fix up the paranoid code to make it work with ipv6. 2009-07-16 22:21:59 -07:00
Love Hörnquist Åstrand
29fc07df5b add paranoid check for PORT and EPRT, make it default
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25330 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-15 22:18:25 +00:00
Love Hörnquist Åstrand
16b76d5cc0 add paranoid
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25329 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-15 22:18:13 +00:00
Love Hörnquist Åstrand
569ee5438c The max_ arguments are really "%.*s" format input paramaters, to make them into ints.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25253 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-28 01:21:08 +00:00
Love Hörnquist Åstrand
1db1289c87 use S_ISDIR
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25230 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-25 23:45:03 +00:00
Love Hörnquist Åstrand
5e4d0f8798 make argument to cwd() const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25142 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 20:39:01 +00:00
Love Hörnquist Åstrand
9b4aafd0ec make argument to cwd() const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25141 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 20:38:47 +00:00
Love Hörnquist Åstrand
22673e4df8 Hide home directory when chrooted or guest. From Ake Holmlund
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25129 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 16:25:36 +00:00
Love Hörnquist Åstrand
5f19fc6a9f use krb5_cc_new_unique()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25033 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:35 +00:00
Love Hörnquist Åstrand
5939a1b0f8 use krb5_cc_new_unique()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25032 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:16 +00:00
Love Hörnquist Åstrand
1747257c60 don't set j to 0, since it never read again
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24924 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-03-22 17:24:15 +00:00
Love Hörnquist Åstrand
54d8d8504c Freeglob is not read again, just free.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24923 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-03-22 17:24:05 +00:00
Love Hörnquist Åstrand
2038ffd351 drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24496 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:28 +00:00
Love Hörnquist Åstrand
a21969d84d drop krb4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24495 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:16 +00:00
Love Hörnquist Åstrand
0bed824d0f drop RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24426 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:42:06 +00:00
Love Hörnquist Åstrand
506125c95a use 'gssapi/*.h'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24422 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:41:29 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
aed77c3b59 ASL_KEY_FACILITY missing on Mac OS X, 10.4, From Mans Nilsson.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23732 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:04:51 +00:00
Love Hörnquist Åstrand
da109cd27f Use asl for logging ftpd wtmp messages.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22951 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-10 10:44:14 +00:00
Love Hörnquist Åstrand
9d1d030025 Use unsigned where appropriate.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22886 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:51:34 +00:00
Love Hörnquist Åstrand
4e58a4c1cd use krb5_free_cred_contents
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22419 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-01-13 09:41:54 +00:00
Love Hörnquist Åstrand
07a870bdf1 move ksetpag after initgroups to make it work on Linux when its without syscall hooks to change sys_setgroups preserve the pag. From abo
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21222 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-20 10:11:14 +00:00
Love Hörnquist Åstrand
77e06cc8fe don't clean yacc/lex files in CLEANFILES, maintainers clean will do that for us.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21031 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 05:00:27 +00:00
Love Hörnquist Åstrand
cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c rename des to hcrypto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
1dee1f3502 Add man_MANS to EXTRA_DIST
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18292 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 10:18:01 +00:00
Love Hörnquist Åstrand
7160948ea6 Add comment by seteuid call isn't not needed.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17873 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-08-08 21:06:11 +00:00
Love Hörnquist Åstrand
7154d3b11d Check return values from seteuid, prompted by MIT advisory.
Thanks to Tom Yu at MIT, and Michael Calmer and Marcus Meissner at SUSE.
Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17872 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-08-08 21:03:26 +00:00
Love Hörnquist Åstrand
4c6a364bf5 (gss_userok): create a local krb5_context and use that instead of the
libgssapi context (that might not exist).


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17690 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-06-27 13:49:06 +00:00
Johan Danielsson
6e777c888a fix grammar in --no-insecure-oob option
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16763 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-02-27 10:04:53 +00:00
Johan Danielsson
52f388ba2f (pass): remove unused variable in the !OTP case
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16530 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-12 16:37:31 +00:00
Love Hörnquist Åstrand
9dccedb6d3 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16216 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 13:15:43 +00:00
Love Hörnquist Åstrand
f74a40ff85 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16215 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 12:49:00 +00:00
Love Hörnquist Åstrand
99a6bdb769 Fix shadow warning.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15677 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-19 18:33:08 +00:00