Commit Graph

15 Commits

Author SHA1 Message Date
Jeffrey Altman
2fda484c2f kuser: generate_requests leaks 'words'
Change-Id: I67a4b4cdab5bf32b9d2b28d8429bb31202cd3b6b
2016-11-18 23:06:04 -05:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0c112865b4 Drop RCSID 2009-08-20 19:03:15 -07:00
Love Hörnquist Åstrand
28c70058fa Close f, from cppcheck
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25278 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-06-08 20:33:33 +00:00
Love Hörnquist Åstrand
27f460b09a use krb5_get_init_creds_password
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24177 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-15 04:28:21 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
3154e1056e Use strcspn to remove \n from string returned by fgets.
From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19233 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-12-06 08:04:05 +00:00
Love Hörnquist Åstrand
495cb953e6 Catch empty file case. From Tobias Stoeckmann.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17051 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-12 12:22:52 +00:00
Love Hörnquist Åstrand
ac8c82785c s/optind/optidx/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15541 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-01 07:14:58 +00:00
Johan Danielsson
26457b7135 replace krb5_free_creds_contents by krb5_free_cred_contents
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13790 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-04-25 19:25:35 +00:00
Assar Westerlund
6dee9a377c parse arguments in a useful way
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10548 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-08-24 01:07:22 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Assar Westerlund
e31d9ba4c2 (generate_requests): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9436 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 07:49:27 +00:00
Assar Westerlund
9e21c6529a new test progrma
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8528 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-02 15:42:33 +00:00