Commit Graph

14 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Asanka Herath
12909ec109 lib/wind: Canonical ordering can't use unstable sort 2010-08-20 13:09:45 -04:00
Love Hornquist Astrand
1e9ec73bbc [HEIMDAL-646] aix
AIX qsort() is unstable and might change the order of the elements
if they are equal, libwind require them to be in the same order as they were
on the input, pull in FreeBSD qsort and use that instead of AIX version.
2009-10-11 15:08:58 -07:00
Love Hornquist Astrand
377543e78e use size_t for index 2009-10-11 14:36:46 -07:00
Love Hornquist Astrand
93f0e450cc fix sizeof, only matter on platforms where sizeof(unsigned) != sizeof(uint32_t) 2009-10-11 12:22:19 -07:00
Love Hornquist Astrand
9bace01559 Check for malloc(0) to make AIX happy
Prompted by [HEIMDAL-646] by Anton Lundin
2009-09-24 07:32:35 -07:00
Love Hornquist Astrand
9e4bc686d3 drop rcsid 2009-09-07 21:22:46 -07:00
Love Hörnquist Åstrand
fea9aa5894 don't set unused variables, move cc to propper scope.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24867 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-27 03:32:42 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
98807b31c1 use generated constant for length, check for overruns, dont use gcc/c99 extentions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22581 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-02-11 20:42:25 +00:00
Love Hörnquist Åstrand
3ad1f2d308 Add and use com_err error codes
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22556 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-02-01 16:38:46 +00:00
Love Hörnquist Åstrand
cd3110ea92 libwind from Assar. stringprep library supporting nameprep, saslprep and ldapprep
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22551 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-02-01 16:22:22 +00:00