Commit Graph

15 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
42e6fb794d avoid const warning 2011-10-29 19:10:20 -07:00
Love Hornquist Astrand
7e36705ee3 use heim_error_t 2011-09-25 18:59:42 +02:00
Love Hornquist Astrand
7a0af9ae18 Its ok to pass down NULL as the context handle to error string function
Just ignore setting the error string if that is the case.
2009-09-21 06:21:23 -07:00
Love Hörnquist Åstrand
ff5dab4f4a remove rcsid
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24795 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-22 23:28:18 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
c69e7f2ae1 Add error documentation
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22332 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-17 01:03:22 +00:00
Love Hörnquist Åstrand
7761ecce3f (hx509_get_error_string): if the error code is not the one we expect,
punt and use the default com_err/strerror string instead.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20912 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-05 03:53:52 +00:00
Love Hörnquist Åstrand
91a0892b93 constify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19840 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-01-11 10:36:29 +00:00
Love Hörnquist Åstrand
82a45c7036 constify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19839 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-01-11 09:55:09 +00:00
Love Hörnquist Åstrand
aaf8aff1c6 (hx509_get_error_string): Put ", " between strings in error message.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19061 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-11-16 15:08:09 +00:00
Love Hörnquist Åstrand
0ae86fa160 Clean error string on failure just to make sure.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18781 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 19:50:31 +00:00
Love Hörnquist Åstrand
eb4b4f87c2 (hx509_set_error_stringv): clear errors on malloc failure
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17401 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-01 15:25:46 +00:00
Love Hörnquist Åstrand
c45fec90c7 Add string error handling functions.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17390 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-01 14:01:32 +00:00