Commit Graph

51 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Jeffrey Altman
36dcd37cc7 use %p printf format spec for pointers
do not cast to unsigned long since a 64-bit pointer
and 32-bit long will truncate the value.

Change-Id: Ibeda98171ccbab4b55950bb02c858773e1028cbf
2011-05-17 12:02:15 -04:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hornquist Astrand
f337b458f3 catch error from as.*printf 2010-05-30 14:16:35 -07:00
Love Hornquist Astrand
788189805c catch error from as.*printf 2010-05-30 13:28:49 -07:00
Love Hornquist Astrand
687db64c56 Patch from Secure Endpoints/Asanka Herath for windows support 2009-12-21 08:45:28 +01:00
Love Hornquist Astrand
4bc5f02317 use HAVE_SCC 2009-11-22 12:23:29 -08:00
Love Hornquist Astrand
14a68d5668 Set umask before creating credentials database to make sure cache is user only readable
Reported by Anton Lundin <glance@acc.umu.se>
2009-08-20 08:40:50 -07:00
Love Hornquist Astrand
a1964f4747 use after free [CID-184] [CID-185] 2009-07-30 07:38:24 +02:00
Love Hörnquist Åstrand
fd5cbcfe3f better free of scache data
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25078 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 05:09:53 +00:00
Love Hörnquist Åstrand
501d4ceadb scache -> scc
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25077 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 05:09:41 +00:00
Love Hörnquist Åstrand
f1d4a3a1da rename SDB to SCC
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25073 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:09:53 +00:00
Love Hörnquist Åstrand
a1992b1ea4 rename SDB to SCC
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25072 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:09:42 +00:00
Love Hörnquist Åstrand
813bb8414b rename SDB to SCC
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25071 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:09:32 +00:00
Love Hörnquist Åstrand
4b7c75eaf8 plug memory leak
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25024 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:00:40 +00:00
Love Hörnquist Åstrand
9001ff8752 drop unused value for exec_stat()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24826 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-27 03:25:42 +00:00
Love Hörnquist Åstrand
3767202e6e drop RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24359 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:31:10 +00:00
Love Hörnquist Åstrand
1abdd59600 dont leak scache context on error, cid#82
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24119 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 05:02:57 +00:00
Love Hörnquist Åstrand
3fd24a3ac3 print pointer with %p
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24076 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 04:54:44 +00:00
Love Hörnquist Åstrand
18038ded5c always include SDB backend
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24031 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-11-12 04:19:10 +00:00
Love Hörnquist Åstrand
106c810509 make scache dependant on sqlite
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23993 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-26 18:27:24 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
d1728c8424 make compile again
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23803 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:36:01 +00:00
Love Hörnquist Åstrand
b29245d5d1 N_()ify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23801 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:35:27 +00:00
Love Hörnquist Åstrand
46158df0d7 use the right database to get the error from.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23666 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-25 02:31:28 +00:00
Love Hörnquist Åstrand
eeab965755 include <sqlite3.h> instead of "sqlite3.h"
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23609 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-17 15:56:32 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
37cc9f4f36 use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23308 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 03:30:33 +00:00
Love Hörnquist Åstrand
3b7ff465c1 Add declspec for Windows
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-17 10:02:03 +00:00
Love Hörnquist Åstrand
adeccfb453 Cast krb5_error_code to int to avoid warning.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22992 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-15 15:55:25 +00:00
Love Hörnquist Åstrand
eb4e9f87d1 (scc_alloc): %x is unsigned int.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22905 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-08 08:16:19 +00:00
Love Hörnquist Åstrand
331b920fdc Add version number to krb5_cc_ops
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22845 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:48:51 +00:00
Love Hörnquist Åstrand
ae1a8c5c2e Implement set_default.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22837 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:48:10 +00:00
Love Hörnquist Åstrand
e7cc54f22b Support delete credential.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22833 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:53 +00:00
Love Hörnquist Åstrand
9ec27909a6 Implement temporary table for interation of caches too.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22831 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:46 +00:00
Love Hörnquist Åstrand
ed493c86ae Do credential iteration by temporary table.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22829 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:38 +00:00
Love Hörnquist Åstrand
5cb55b4baf Make default cache work.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22828 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:34 +00:00
Love Hörnquist Åstrand
d18af98b63 Search backward for :, make sample name not include :
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22827 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:30 +00:00
Love Hörnquist Åstrand
cdadd5e9ce first try to get the default cache code right
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22826 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:26 +00:00
Love Hörnquist Åstrand
4fa7c09faf Make it pass most of the tests.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22822 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:47:07 +00:00
Love Hörnquist Åstrand
7b897bbaa6 Implement cache iteration and clean up modue.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22817 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:46:46 +00:00
Love Hörnquist Åstrand
aac08b6b46 Implement destroy.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22816 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:46:42 +00:00
Love Hörnquist Åstrand
8475d4d2a2 Make somewhat more working...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:46:37 +00:00
Love Hörnquist Åstrand
fce1b56ca5 Make compile.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:46:33 +00:00
Love Hörnquist Åstrand
703c3751ec Make the cache less broken, not working yet.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22813 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 11:46:28 +00:00