Commit Graph

46 Commits

Author SHA1 Message Date
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Nicolas Williams e23a1efdc9 Fixes for updates of KADM5_KVNO but not KEY_DATA and vice-versa.
It turns out that updates of kvno but not key data and vice-versa are
both, allowed and actually done (e.g, in kadmin's ank).  Doing the right
thing in these cases turns out to be a bit tricky, but this commit ought
to do it.
2011-07-22 16:07:10 -05:00
Nicolas Williams e020dc25b8 Fix a double free in ank.c. 2011-07-22 16:07:08 -05:00
Nicolas Williams 1f349a6aba kadmin support for policies. 2011-07-22 16:05:21 -05:00
Love Hornquist Astrand f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Love Hornquist Astrand 433b1d5073 drop RCSID 2010-03-16 12:52:58 -07:00
Love Hörnquist Åstrand 0c6e235109 use krb5_principal_get_realm
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25119 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-16 08:15:44 +00:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand 7fcd266fdd use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand 091fba8a25 return 1 on failure, update (c)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16658 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-25 12:29:46 +00:00
Love Hörnquist Åstrand d12920441b (add_new_key): return 1 on failure.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16654 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-25 12:18:41 +00:00
Love Hörnquist Åstrand 192b125577 (add_one_principal): catch error from UI_UTIL_read_pw_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14332 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-11-01 08:41:00 +00:00
Johan Danielsson 5836537f76 argument number checks are now done by slc
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-05 11:41:22 +00:00
Johan Danielsson d970c48c81 print error messages to stderr; change all in-string quoting to use "
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14021 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-04 15:09:42 +00:00
Love Hörnquist Åstrand 429fc15b79 fix slc lossage
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14016 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-02 13:38:45 +00:00
Johan Danielsson 9929f779ec move kadmin-commands.h from kadmin_locl.h so kadmind does not depend on it
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14000 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-27 15:04:07 +00:00
Johan Danielsson d7f9fac88e convert to use slc; also add stash subcommand
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13970 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-21 19:19:45 +00:00
Love Hörnquist Åstrand 5095f7bbc3 (add_one_principal): even though the principal is disabled (creation
of random key/keydata), create it with a random password


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13447 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-07 14:31:26 +00:00
Love Hörnquist Åstrand a0714dedc6 (add_one_principal): pass right argument to kadm5_free_principal_ent
From Panasas, Inc


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13200 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-12-07 19:26:26 +00:00
Love Hörnquist Åstrand 8b66e46474 s/des_read_pw_string/UI_UTIL_read_pw_string/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12759 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 11:47:30 +00:00
Johan Danielsson 4fcac6e9be (add_one_principal): check return value from edit_entry
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11556 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-12-03 14:11:24 +00:00
Johan Danielsson 5807150c8b (add_one_principal): don't continue if create_principal fails
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11555 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-12-03 14:10:30 +00:00
Jacques A. Vidrine 29538a775a Do not attempt to free uninitialized pointer when
kadm5_randkey_principal fails.  This would most likely
be encountered when one does not have change-password
rights, but uses one of the `--random-key' or `--random-password'
options of the ank command.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11036 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-06-07 19:05:38 +00:00
Johan Danielsson bd603d56fa add a --use-defaults option to just use default values without questions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10459 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-08-10 08:08:22 +00:00
Johan Danielsson 3e24852f6d calling the command `add' make more sense from an english pov
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9042 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-09-10 19:16:39 +00:00
Assar Westerlund 4bfe69645d add --key
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8052 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-03-23 15:20:43 +00:00
Johan Danielsson c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Assar Westerlund 6f070d95ce (add_one_principal): `password' can cactually be NULL in the overwrite
code, check for it.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7070 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-01 15:16:41 +00:00
Assar Westerlund d3f5d79294 strc{py,at}_truncate -> strlc{py,at}
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-16 21:39:11 +00:00
Assar Westerlund 269432f82f (add_one_principal): initialize `default_ent'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6863 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-24 23:26:17 +00:00
Assar Westerlund c22bb92415 add support for --random-password
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6853 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-21 12:38:58 +00:00
Assar Westerlund 82218a6ea7 add setting of expiration and password expiration
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6846 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-19 20:30:44 +00:00
Assar Westerlund be29622761 (add_one_principal): allow setting expiration times
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6500 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-07-23 22:09:33 +00:00
Assar Westerlund 2faa266a21 make ank use the values of the default principal for prompting
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6352 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-06-23 12:37:05 +00:00
Assar Westerlund 2db8ae77eb (add_new_key): initialize more variables
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6147 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-07 19:02:49 +00:00
Assar Westerlund a6b7e36937 (add_new_key): new options for setting max-ticket-life,
max-renewable-life, and attributes


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6125 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-04 18:39:50 +00:00
Johan Danielsson aaae186ab9 merge new-crypto branch
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5332 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-02-11 21:03:59 +00:00
Assar Westerlund fc1956b05f new arg_printusage
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5130 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-08-18 21:17:01 +00:00
Assar Westerlund e9d0112abf (ank): don't zero password if --random-key was given.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4241 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-12-25 16:02:34 +00:00
Assar Westerlund 9c2a129e37 (add_new_key): test the return value of `krb5_parse_name'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4214 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-12-17 03:17:53 +00:00
Johan Danielsson dede654dd9 Set initial kvno to 1.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4095 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-12-04 03:57:39 +00:00
Johan Danielsson db481f8bed Free keys.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4029 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-16 10:53:25 +00:00
Johan Danielsson 297c5c606b Implement setting some more values.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3936 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-11 20:39:13 +00:00
Johan Danielsson af364bca96 less leaks
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3833 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-09 01:18:20 +00:00
Johan Danielsson a9f1581a4c Simple kadmin utility.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3738 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-01 02:53:06 +00:00