oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,184 Commits 2 Branches 2 Tags
01e7b326b6442d8fa3965a91f73ca56b901caae7
Commit Graph

58 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
f9f78a2cbf kadm5_log_reinit() needs to obtain its lock before truncating the file. 
We can't use O_TRUNC on open because (without O_EXLOCK which is
not portable) we would be modifying the file without an exclusive
lock.  So, we drop the use of O_TRUNC and use ftruncate(2) after
obtaining the lock via flock(2).
 2012-05-31 17:30:29 +01:00
Nicolas Williams
ef9012aef5 Fix ipropd-slave assert when doing del_enctype 
Change a paranoid heim_assert into something better.  Update block
    comment.

    Next commit: add a test for del_enctype and iprop.
 2012-03-15 18:57:32 -05:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Nicolas Williams
a7717ae4f9 Use heim_assert() instead of assert() 2011-07-24 11:10:37 -05:00
Nicolas Williams
909653e50f Add comment and assert about key history to kadm5_log_replay_modify() 2011-07-22 16:07:07 -05:00
Nicolas Williams
7e0a801e28 Changed decrypt key history logic and added HDB_F_ALL_KVNOS. 2011-07-22 16:05:21 -05:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Love Hornquist Astrand
9427bcc22e log more version numbers 2011-01-03 12:12:18 +01:00
Love Hornquist Astrand
965836509b switch to hdb_fetch_kvno 2010-11-28 11:43:02 -08:00
Asanka Herath
d84119813e No AF_UNIX on Windows and no SIGPIPE and SIGXCPU 2009-11-24 10:12:44 -08:00
Love Hornquist Astrand
ff87429593 Make LDAP code fetch less attributes from LDAP server when KDC is asking 
Johan Gadsjö did a awesome analysis of the LDAP access pattens
and sent us a patch that reduced the calls the ldap server by 4
times as many. The patch was adopted and change to avoid compile
time depencies and make the determination runtime instead. Thanks!
 2009-10-03 13:20:41 -07:00
Love Hörnquist Åstrand
a8a2e8140b catch failure 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25203 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-09 14:21:29 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
284d45bbbc use hdb_db_dir() and hdb_default_db() 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22211 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-07 19:27:27 +00:00
Love Hörnquist Åstrand
5fed824f37 its vs it\'s etc. From Bjorn Sandell 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22071 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-11-14 20:04:50 +00:00
Love Hörnquist Åstrand
fb492fba05 Unexport the specific log replay operations. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21908 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-08-16 10:14:16 +00:00
Love Hörnquist Åstrand
5670ef2f52 Sprinkle krb5_set_error_string(). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21834 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-08-07 18:55:46 +00:00
Love Hörnquist Åstrand
61f73a98ff (kadm5_log_foreach): check that the postamble contains the right data. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21807 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-08-03 13:44:40 +00:00
Love Hörnquist Åstrand
a883bbfd49 only free the orignal entries extentions if there was any. 
Bug reported byg Peter Meinecke.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21764 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-07-31 22:35:08 +00:00
Love Hörnquist Åstrand
0382061b7b add configuration for signal file and acl file, let user select hostname, catch signals and print why we are quiting, make nop cause one new version, not two 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21756 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-07-31 22:15:08 +00:00
Love Hörnquist Åstrand
8d40c2994b check return value of alloc functions, from Charles Longeau 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21745 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-07-31 16:11:25 +00:00
Love Hörnquist Åstrand
871b9cab4a make it slightly more working. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20600 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-05-08 03:01:25 +00:00
Love Hörnquist Åstrand
0018da82f1 (kadm5_log_previous): document assumptions and make less broken. 
Bug report from Ronny Blomme.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20584 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-05-08 00:40:47 +00:00
Love Hörnquist Åstrand
cb704efeeb Rename u_intXX_t to uintXX_t 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17445 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-05-05 10:37:46 +00:00
Love Hörnquist Åstrand
eea5f34855 Pass in HDB_F_GET_ANY to all ->hdb fetch to hint what entries we are looking for 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17313 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-27 11:18:52 +00:00
Love Hörnquist Åstrand
5f22b44baa Break out the that we request from principal from the entry and pass 
it in as a separate argument.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17310 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-27 11:09:30 +00:00
Love Hörnquist Åstrand
ed777eb383 (kadm5_log_delete): add error handling Coverity, NetBSD CID#626 
(kadm5_log_modify): add error handling Coverity, NetBSD CID#627


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17031 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-10 08:25:13 +00:00
Love Hörnquist Åstrand
ce43c5de5a (kadm5_log_rename): handle errors better 
Fixes Coverity, NetBSD CID#628


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17030 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-10 08:16:41 +00:00
Love Hörnquist Åstrand
50fbd27e73 memset hdb_entry_ex before use 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16394 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-12-13 11:46:05 +00:00
Love Hörnquist Åstrand
0c2369acd0 Wrap hdb_entry with hdb_entry_ex, patch originally from Andrew Bartlet 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16378 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-12-12 12:40:12 +00:00
Love Hörnquist Åstrand
665577dc46 (kadm5_log_init): set error string on failures 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16320 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-11-30 12:27:07 +00:00
Love Hörnquist Åstrand
f30e13f441 (kadm5_log_foreach): add a context variable and pass it down to `func´. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15975 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-08-24 18:10:27 +00:00
Love Hörnquist Åstrand
f634448adf (kadm5_log_previous): catch errors instead of asserting and set error string. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15969 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-08-24 14:26:23 +00:00
Love Hörnquist Åstrand
4c01f36c26 (kadm5_log_replay_modify): Check return values of malloc(), replace 
all extensions.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15886 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-08-11 13:38:24 +00:00
Love Hörnquist Åstrand
77abb72eb2 rename shadowing len to num 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15483 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-06-17 05:18:20 +00:00
Love Hörnquist Åstrand
0540f13b86 prefix all struct HDB elements with hdb_ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12880 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-09-19 00:25:35 +00:00
Love Hörnquist Åstrand
58eb3ca46b check return values from krb5_data_alloc 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12065 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 17:58:59 +00:00
Johan Danielsson
4fa94362ee fix for storage change 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11021 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-05-24 15:23:43 +00:00
Assar Westerlund
ed3264222f (kadm5_log_get_version): rename kadm5_log_get_version_fd and make a 
new that takes a context
(kadm5_log_nop): add logging of missing lengths
(kadm5_log_truncate): new function


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8805 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-24 04:32:17 +00:00
Assar Westerlund
30fcaa8cc4 fix typo 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8349 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-06-07 11:10:24 +00:00
Assar Westerlund
386538399f (kadm5_log_replay_create): handle more NULL pointers (should they 
really happen?)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8338 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-06-07 02:55:46 +00:00
Assar Westerlund
388b1f5dad (kadm5_log_replay_modify): handle max_life == NULL and max_renew == 
NULL


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8333 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-06-07 01:57:31 +00:00
Assar Westerlund
d96fcfdae2 (kadm5_log_set_version, kadm5_log_reinit, kadm5_log_nop, 
kadm5_log_replay_nop): add


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8318 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-06-05 17:04:54 +00:00
Assar Westerlund
8029d00e06 (kadm5_log_foreach): change to take a `kadm5_server_context' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7509 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-04 19:50:35 +00:00
Johan Danielsson
71d323c1b9 (kadm5_log_foreach): pass context 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7479 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-03 13:00:42 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Assar Westerlund
ce45358477 (kadm5_log_flush): extra cast 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6489 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-07-22 11:40:55 +00:00
Johan Danielsson
c3e59002fe add flags to fetch and store; seal keys before logging 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6097 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-03 17:09:58 +00:00