22 Commits

Author SHA1 Message Date
Nicolas Williams
fb553dde1d krb5: Fix warnings 2022-01-14 17:10:16 -06:00
Nicolas Williams
5f63215d0d Always perform == or != operation on cmp function result
Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.

This change converts all use of cmp function usage from

```
    if (strcmp(a, b) || !strcmp(c, d)) ...
```

to

```
    if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```

for all C library cmp functions and related:

 - strcmp(), strncmp()
 - strcasecmp(), strncasecmp()
 - stricmp(), strnicmp()
 - memcmp()

Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188
2021-11-24 22:30:44 -05:00
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
687db64c56 Patch from Secure Endpoints/Asanka Herath for windows support 2009-12-21 08:45:28 +01:00
Love Hornquist Astrand
0a4b702cf1 less dup rk_ 2009-12-13 12:22:33 -08:00
Love Hornquist Astrand
75aa4b44fa switch to rk_strerror_r 2009-12-13 11:42:12 -08:00
Love Hornquist Astrand
682c5e5867 Use strerror_r 2009-10-12 09:07:31 -07:00
Love Hörnquist Åstrand
942a821fab remove RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
4f023f744b provide i18n hooks and renew krb5_create_checksum_iov from comments from metze
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23733 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:06:34 +00:00
Love Hörnquist Åstrand
a49e280f58 close-on-exec
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23453 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-27 12:11:16 +00:00
Love Hörnquist Åstrand
854ef9a202 switch to krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23273 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 03:25:00 +00:00
Love Hörnquist Åstrand
1816bb6dce quote?
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22119 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-03 22:02:48 +00:00
Love Hörnquist Åstrand
c6a3b40dc7 doxygen documentation
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22040 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-11-10 12:55:37 +00:00
Love Hörnquist Åstrand
828197fc78 (acl_parse_format): tmp needs to be freed too on failure to parse
format specifier.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16345 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-12-02 15:33:47 +00:00
Love Hörnquist Åstrand
91351971f7 add KRB5_LIB_FUNCTION to all exported functions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13863 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-05-25 21:46:46 +00:00
Love Hörnquist Åstrand
4b69fa3283 plug memory leak on file matching
make it not fall over when no non matching acl
make fnmatch matching useful by switching arguments


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13549 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-20 07:05:46 +00:00
Johan Danielsson
9238c90cfa rename acl_string parameter
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10939 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-04-18 16:16:24 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-05-14 06:14:52 +00:00
Johan Danielsson
778ab452c8 slightly generic acl code
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8385 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-12 11:17:52 +00:00