17 Commits

Author SHA1 Message Date
Jeffrey Altman
51575264d4 kadmin: read_words pass correct type to sizeof
(char *) not (char **).

Change-Id: I2c34fa5b0ea9f81b08451ed1b4a816684b7ab638
2022-01-17 22:36:29 -05:00
Jeffrey Altman
11d1c81c27 kadmin: add_users leaks 'words'
Change-Id: I2607c8f0d774dd31d3b7f2341a65f4d43867548f
2016-11-19 00:21:42 -05:00
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
433b1d5073 drop RCSID 2010-03-16 12:52:58 -07:00
Love Hörnquist Åstrand
f6fa5c810e Close f, from cppcheck
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25276 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-06-08 20:33:12 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
487bcca4e2 Use strcspn to remove \n from fgets result. Prompted by change by Ray
Lai of OpenBSD via Björn Sandell.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19213 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-12-04 23:36:36 +00:00
Love Hörnquist Åstrand
495cb953e6 Catch empty file case. From Tobias Stoeckmann.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17051 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-12 12:22:52 +00:00
Love Hörnquist Åstrand
5654000990 lower amount of shadow and const warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15587 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-07 22:06:50 +00:00
Assar Westerlund
9bfda0d538 allocate several buffers for the list of words, instead of one strdup
per word (running under efence does not work very well otherwise)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10731 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-20 09:17:33 +00:00
Assar Westerlund
34f7c247b6 allow specifying the number of users to create
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10694 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-13 01:46:51 +00:00
Assar Westerlund
c9d22e0c67 (main): handle --version
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10408 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-07-31 01:21:50 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Assar Westerlund
fdbca0e168 (add_user): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9435 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 07:43:39 +00:00
Assar Westerlund
7e0ba9e140 testing program, add random users
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8348 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-07 11:08:02 +00:00