19 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
149edc15f7 Free krb5_auth_context [CID-95] 2009-07-30 12:03:33 +02:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
13525ea454 case uid_t to unsigned long in printf format
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15246 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-27 13:47:20 +00:00
Love Hörnquist Åstrand
6e6b40f359 (kfd_match_version): cast argument to islower to unsigned char
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14493 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-01-08 22:27:28 +00:00
Love Hörnquist Åstrand
9132cd6d89 use strlcpy, from openbsd
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12041 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-16 15:40:24 +00:00
Johan Danielsson
4c81cc848e use krb5_err instead of sysloging directly, handle the new protocol,
and bail out if an old client tries to connect


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11377 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-04 20:31:48 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Assar Westerlund
d5afbdaa01 (proto): use krb5_rd_cred2 instead of krb5_rd_cred
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9463 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-01-09 18:43:10 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at}
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-16 21:39:11 +00:00
Assar Westerlund
d00feda10d (proto): be more careful with the return value from krb5_net_read
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6818 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-16 12:26:25 +00:00
Assar Westerlund
106427eaa1 make v6 friendly and simplify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6751 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-05 11:39:57 +00:00
Assar Westerlund
0412defc7b add regpag support. From Miroslav Ruda <ruda@ics.muni.cz>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6707 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-04 16:57:03 +00:00
Assar Westerlund
8b1b51391f clean-up and more paranoia
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6495 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-07-23 21:38:54 +00:00
Assar Westerlund
aef43355c9 new program
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6486 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-07-22 11:36:30 +00:00