oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
30,889 Commits 2 Branches 2 Tags
master
Commit Graph

57 Commits

Author SHA1 Message Date
Jeffrey Altman
3a52803e19 appl/kf: doit close socket before returning 
Change-Id: Ida564ea4c27c1bd50004340ac7dbab5f11dbf531
 2022-01-17 16:50:42 -05:00
Nicolas Williams
5f63215d0d Always perform == or != operation on cmp function result 
Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.

This change converts all use of cmp function usage from

```
    if (strcmp(a, b) || !strcmp(c, d)) ...
```

to

```
    if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```

for all C library cmp functions and related:

 - strcmp(), strncmp()
 - strcasecmp(), strncasecmp()
 - stricmp(), strnicmp()
 - memcmp()

Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188
 2021-11-24 22:30:44 -05:00
Nicolas Williams
3f1451a4c3 Remove get_default_username() 2018-12-25 22:11:19 -06:00
Nicolas Williams
8e5e8aacbc Misc fixes to man pages 
Originally by Christos Zoulas.
 2017-03-13 18:39:41 -04:00
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
db8e287e41 Use "Fl Fl" for long options. 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2011-05-21 11:54:14 -07:00
Asanka Herath
d00f9984a5 Make roken build on windows 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
149edc15f7 Free krb5_auth_context [CID-95] 2009-07-30 12:03:33 +02:00
Love Hornquist Astrand
b2aaf4f306 free auth_context on close [CID-97] 2009-07-30 11:55:42 +02:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
cc4333b758 remove cvs ignore files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c rename des to hcrypto 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
1dee1f3502 Add man_MANS to EXTRA_DIST 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18292 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-07 10:18:01 +00:00
Love Hörnquist Åstrand
13525ea454 case uid_t to unsigned long in printf format 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15246 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-27 13:47:20 +00:00
Love Hörnquist Åstrand
6e6b40f359 (kfd_match_version): cast argument to islower to unsigned char 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14493 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-01-08 22:27:28 +00:00
Love Hörnquist Åstrand
9132cd6d89 use strlcpy, from openbsd 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12041 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 15:40:24 +00:00
Love Hörnquist Åstrand
8ac349f52f spellings, from jmc <jmc@prioris.mini.pw.edu.pl> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11986 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-11 12:43:57 +00:00
Love Hörnquist Åstrand
b4a0957905 afs->AFS, from jmc <jmc@acn.waw.pl> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11947 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-03-31 15:34:53 +00:00
Love Hörnquist Åstrand
bc61a0c564 s/securly/securely/ from NetBSD 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11663 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-02-25 10:52:59 +00:00
Love Hörnquist Åstrand
aa25cfcafa add copyright/license statment 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11648 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-02-16 21:10:32 +00:00
Johan Danielsson
af36f87126 fix warning string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11400 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-05 15:00:03 +00:00
Johan Danielsson
cfcf1125e9 handle new protocol 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11378 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-04 20:32:18 +00:00
Johan Danielsson
4c81cc848e use krb5_err instead of sysloging directly, handle the new protocol, 
and bail out if an old client tries to connect


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11377 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-04 20:31:48 +00:00
Johan Danielsson
4553415279 we need a protocol version string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11376 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-04 20:29:04 +00:00
Johan Danielsson
747a00df69 remove Ns before comma (from Thomas Klausner) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11175 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-08-20 16:37:20 +00:00
Johan Danielsson
e55ce037ed x 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10229 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-07-02 20:11:41 +00:00
Assar Westerlund
25ad02d691 mdoc fixes from ru@freebsd.org 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9830 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-02 08:59:23 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
d5afbdaa01 (proto): use krb5_rd_cred2 instead of krb5_rd_cred 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9463 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-09 18:43:10 +00:00
Assar Westerlund
633782864b (main): handle krb5_init_context failure consistently 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9443 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-31 08:05:03 +00:00
Assar Westerlund
baebf953a8 use LIB_des 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9176 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-11-15 22:51:14 +00:00
Assar Westerlund
404e539135 actually install 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8637 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-10 03:19:20 +00:00
Assar Westerlund
d730184472 add kfd.8 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8524 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-02 05:22:36 +00:00
Assar Westerlund
ae5e25c72c (man_MANS): add kf.1 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8523 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-02 05:16:53 +00:00
Assar Westerlund
58fe133a4f contributed by lha@s3.kth.se 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8522 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-02 05:16:33 +00:00
Assar Westerlund
c33ef3747d (doit): rewrite to use getaddrinfo 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7495 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-04 18:04:09 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at} 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-16 21:39:11 +00:00
Assar Westerlund
c139c81e0d (proto): don't trust errno if krb5_net_read hasn't returned -1 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6825 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-16 12:43:43 +00:00
Assar Westerlund
d00feda10d (proto): be more careful with the return value from krb5_net_read 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6818 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-16 12:26:25 +00:00
Assar Westerlund
fd6e3126dc (doit): call freehostent 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6752 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-05 12:19:45 +00:00
Assar Westerlund
106427eaa1 make v6 friendly and simplify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6751 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-05 11:39:57 +00:00
Assar Westerlund
0412defc7b add regpag support. From Miroslav Ruda <ruda@ics.muni.cz> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6707 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-04 16:57:03 +00:00
Assar Westerlund
cd4006ff87 add `-G' and forwardable option in krb5.conf. From Miroslav Ruda 
<ruda@ics.muni.cz>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6706 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-04 16:56:46 +00:00
Assar Westerlund
ac82f4ac5c (main): use warnx 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6518 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-07-24 09:23:03 +00:00