113 Commits

Author SHA1 Message Date
Jeffrey Altman
cd91a3a03e appl/afsutil: expand_cell_name return NULL if not found
In function ‘afslog_cell.isra’:
  afslog.c:144:13: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
  144 |            warnx("No cell matching \"%s\" found.", cell);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

caused by expand_cell_name() returning the input pointer.
Alter the behavior of expand_cell_name() to match its usage.

Change-Id: I3b15c4b3e59b597af5351e5e62f5d7751be50feb
2022-01-21 08:51:28 -05:00
Nicolas Williams
620862049e Use roken_get_*() instead of getpwuuid()
Using non-reentrant getpwuid() (or getpwnam(), or getspnam())  can be
dangerous.  We had a report of a login application / PAM that calls
those, and Heimdal, by calling them too, clobbered the cached struct
passwd used by the login app / PAM.
2018-12-25 22:11:19 -06:00
Nicolas Williams
8e5e8aacbc Misc fixes to man pages
Originally by Christos Zoulas.
2017-03-13 18:39:41 -04:00
Jelmer Vernooij
5a75d6fe43 afslog.1: Remove documentation for removed no-v4 argument. 2014-06-02 00:32:37 +02:00
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
1828443089 drop krb4 2011-08-10 09:26:20 -07:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
97df66c0a0 Put Nd argument after Nd macro.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:27 -07:00
Thomas Klausner
db8e287e41 Use "Fl Fl" for long options.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:14 -07:00
Love Hornquist Astrand
9f244d27cc use krb5_warn 2010-11-25 10:51:30 -08:00
Love Hornquist Astrand
0e97f54b54 man fixes
Add two cross references, expansion of PAG, and expansion of the -c
argument to the OpenBSD tech list earlier.

From Lars Nooden
2010-05-03 10:38:41 +02:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
98f2421134 Use krb5_cc_get_type() to get the type, dont assume typename_arg is set
Patch from Johan Gadsjö via Joakim Fallsjö
2009-09-24 07:19:33 -07:00
Love Hornquist Astrand
e977f1cf2f You don't exists [CID-60] 2009-07-30 13:03:27 +02:00
Love Hörnquist Åstrand
3b04ca2afd simplify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25031 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:04 +00:00
Love Hörnquist Åstrand
1d1a2af1a6 no krb4
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24535 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-28 00:43:14 +00:00
Love Hörnquist Åstrand
3a2db6c8ea kill krb4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24494 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:01 +00:00
Love Hörnquist Åstrand
fe1a976ae2 new krb5_cc_cache_match
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23905 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-13 03:03:21 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
e36a5a60a5 Use unsigned where appropriate.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22885 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:51:30 +00:00
Love Hörnquist Åstrand
cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c rename des to hcrypto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
d1b8c3d056 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20312 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-11 11:28:09 +00:00
Love Hörnquist Åstrand
44495dda82 - options must be lexicographically ordered; again, options without
arguments must be placed before options with arguments.
- manual page cross references are done using the macro `.Xr',
  not the macro `.Nm' (used for command names instead).

From Igor Sobrado.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20311 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-11 11:27:51 +00:00
Love Hörnquist Åstrand
f4f67cc4d7 - options must be lexicographically ordered; again, options without
arguments must be placed before options with arguments.
- manual page cross references are done using the macro `.Xr',
  not the macro `.Nm' (used for command names instead).

From Igor Sobrado.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20310 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-11 11:22:23 +00:00
Love Hörnquist Åstrand
103231471e x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18293 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 10:18:16 +00:00
Love Hörnquist Åstrand
1dee1f3502 Add man_MANS to EXTRA_DIST
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18292 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 10:18:01 +00:00
Love Hörnquist Åstrand
3f88fe5a90 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16440 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-03 09:28:36 +00:00
Love Hörnquist Åstrand
106b3af386 Document options to allow select principal or credential cache when
doing afslog.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16439 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-03 09:28:25 +00:00
Love Hörnquist Åstrand
44a367881b Add options to allow select principal or credential cache when doing afslog.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16438 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-03 09:27:54 +00:00
Love Hörnquist Åstrand
46a77c28e4 pagsh is in section 1
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14827 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-18 10:20:31 +00:00
Love Hörnquist Åstrand
3aa848647e x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14788 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-13 19:22:19 +00:00
Love Hörnquist Åstrand
fd05385450 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14577 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-02-12 14:34:05 +00:00
Love Hörnquist Åstrand
d592d092c7 man_MANS += pagsh.1
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14576 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-02-12 14:27:01 +00:00
Love Hörnquist Åstrand
17dc617a7f x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14575 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-02-12 14:24:06 +00:00
Love Hörnquist Åstrand
aeedc46505 add --cache-type that allows the user to control the resulting
credential cache type, inherit the type from the invoking process


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14574 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-02-12 14:23:28 +00:00
Love Hörnquist Åstrand
fb681cc82f manpag for pagsh
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14573 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-02-12 14:21:01 +00:00
Love Hörnquist Åstrand
886e3ba278 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14186 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-03 12:12:03 +00:00
Love Hörnquist Åstrand
0a57899d04 use negative string help string for arg_negative_flag
Pointed out by Harald Barth


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14185 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-03 12:11:40 +00:00
Johan Danielsson
0624b4457e replace INCLUDES with AM_CPPFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14164 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-26 11:55:29 +00:00
Love Hörnquist Åstrand
74b71128e5 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14084 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-27 10:52:51 +00:00
Love Hörnquist Åstrand
3409351eec use setprogname
if we stripped off -c, try use the fallback code


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14083 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-27 10:52:38 +00:00
Johan Danielsson
175541b3c3 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13015 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-10-14 12:32:54 +00:00
Johan Danielsson
3a36f7c6db mkstemp formats must end in exactly six X's
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13014 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-10-14 12:32:39 +00:00
Love Hörnquist Åstrand
72c26c7cce x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12437 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-07-15 12:56:59 +00:00
Love Hörnquist Åstrand
801e3f9334 (do_afslog): is cell is unset, set it "<default cell>" for error printing
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12436 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-07-15 12:56:00 +00:00
Love Hörnquist Åstrand
b48c005971 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12435 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-07-15 12:40:04 +00:00