oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

gsskrb5: Add missing unlock in _gsskrb5_duplicate_cred() failure case

Browse Source
This commit is contained in:
Nicolas Williams
2023-01-04 16:20:32 -06:00
parent 485b5d575a
commit f99145ad78
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/gssapi/krb5/duplicate_cred.c
View File

@@ -76,12 +76,6 @@ OM_uint32 GSSAPI_CALLCONV _gsskrb5_duplicate_cred (
HEIMDAL_MUTEX_lock(&cred->cred_id_mutex); HEIMDAL_MUTEX_lock(&cred->cred_id_mutex);
dup->destination_realm = NULL; dup->destination_realm = NULL;
if (cred->destination_realm &&
(dup->destination_realm = strdup(cred->destination_realm)) == NULL) {
*minor_status = krb5_enomem(context);
free(dup);
return (GSS_S_FAILURE);
}
dup->usage = cred->usage; dup->usage = cred->usage;
dup->endtime = cred->endtime; dup->endtime = cred->endtime;
dup->principal = NULL; dup->principal = NULL;
@@ -92,6 +86,11 @@ OM_uint32 GSSAPI_CALLCONV _gsskrb5_duplicate_cred (
major = GSS_S_FAILURE; major = GSS_S_FAILURE;
HEIMDAL_MUTEX_init(&dup->cred_id_mutex); HEIMDAL_MUTEX_init(&dup->cred_id_mutex);
if (cred->destination_realm &&
(dup->destination_realm = strdup(cred->destination_realm)) == NULL) {
*minor_status = krb5_enomem(context);
goto fail;
}
*minor_status = krb5_copy_principal(context, cred->principal, *minor_status = krb5_copy_principal(context, cred->principal,
&dup->principal); &dup->principal);
if (*minor_status) if (*minor_status)