oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

ipc: Quiet warning about ignoring fcntl() and chmod() return values

Browse Source
This commit is contained in:
Nicolas Williams
2023-01-04 16:05:38 -06:00
parent c157054c51
commit ede0c59d4b
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ipc/server.c
View File

@@ -606,7 +606,6 @@ add_new_socket(int fd,
void *userctx) void *userctx)
{ {
struct client *c; struct client *c;
int fileflags;
c = calloc(1, sizeof(*c)); c = calloc(1, sizeof(*c));
if (c == NULL) if (c == NULL)
@@ -628,8 +627,7 @@ add_new_socket(int fd,
c->callback = callback; c->callback = callback;
c->userctx = userctx; c->userctx = userctx;
fileflags = fcntl(c->fd, F_GETFL, 0); socket_set_nonblocking(fd, 1);
fcntl(c->fd, F_SETFL, fileflags | O_NONBLOCK);
#ifdef HAVE_GCD #ifdef HAVE_GCD
init_globals(); init_globals();
@@ -1118,7 +1116,7 @@ heim_sipc_service_unix(const char *service,
return errno; return errno;
} }
chmod(un.sun_path, 0666); (void) chmod(un.sun_path, 0666);
ret = heim_sipc_stream_listener(fd, HEIM_SIPC_TYPE_IPC, ret = heim_sipc_stream_listener(fd, HEIM_SIPC_TYPE_IPC,
callback, user, ctx); callback, user, ctx);
@@ -1287,7 +1285,7 @@ heim_sipc_service_door(const char *service,
ret = errno; ret = errno;
goto cleanup; goto cleanup;
} }
fchmod(dfd, 0666); /* XXX */ (void) fchmod(dfd, 0666); /* XXX */
if (fattach(fd, path) < 0) { if (fattach(fd, path) < 0) {
ret = errno; ret = errno;