oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

heimdal: Use krb5_free_default_realm() for free()

Browse Source 
The resource allocated by krb5_default_default_realm() should be
free()'d by krb5_free_default_realm() instead of plain free()
for better readability.

Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Santosh Kumar Pradhan
2014-02-21 09:48:31 +05:30
committed by Nicolas Williams
parent 324ac13b32
commit e5144acab0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/krb5/principal.c
View File

@@ -360,7 +360,7 @@ exit:
free(comp[--n]); free(comp[--n]);
} }
free(comp); free(comp);
free(realm); krb5_free_default_realm(context, realm);
free(s); free(s);
return ret; return ret;
} }
@@ -449,7 +449,7 @@ unparse_name_fixed(krb5_context context,
return ret; return ret;
if(strcmp(princ_realm(principal), r) != 0) if(strcmp(princ_realm(principal), r) != 0)
short_form = 0; short_form = 0;
free(r); krb5_free_default_realm(context, r);
} }
if(!short_form && !no_realm) { if(!short_form && !no_realm) {
add_char(name, idx, len, '@'); add_char(name, idx, len, '@');
@@ -747,7 +747,7 @@ krb5_make_principal(krb5_context context,
ret = krb5_build_principal_va(context, principal, strlen(realm), realm, ap); ret = krb5_build_principal_va(context, principal, strlen(realm), realm, ap);
va_end(ap); va_end(ap);
if(r) if(r)
free(r); krb5_free_default_realm(context, r);
return ret; return ret;
} }