oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kadmin: Fix uninit variable in cpw --key

Browse Source
This commit is contained in:
Nicolas Williams
2023-01-03 20:50:37 -06:00
parent 95a458adbd
commit dfe592ef35
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
kadmin/cpw.c
View File

@@ -156,8 +156,10 @@ cpw_entry(struct passwd_options *opt, int argc, char **argv)
int i; int i;
struct cpw_entry_data data; struct cpw_entry_data data;
int num; int num;
int16_t n_key_data = 0;
krb5_key_data key_data[3]; krb5_key_data key_data[3];
memset(key_data, 0, sizeof(key_data));
data.kadm_handle = NULL; data.kadm_handle = NULL;
ret = kadm5_dup_context(kadm_handle, &data.kadm_handle); ret = kadm5_dup_context(kadm_handle, &data.kadm_handle);
if (ret) if (ret)
@@ -214,6 +216,7 @@ cpw_entry(struct passwd_options *opt, int argc, char **argv)
opt->key_string, error); opt->key_string, error);
return 1; return 1;
} }
n_key_data = sizeof(key_data)/sizeof(key_data[0]);
data.key_data = key_data; data.key_data = key_data;
} }
@@ -222,10 +225,8 @@ cpw_entry(struct passwd_options *opt, int argc, char **argv)
kadm5_destroy(data.kadm_handle); kadm5_destroy(data.kadm_handle);
if (data.key_data) { if (opt->key_string)
int16_t dummy; kadm5_free_key_data(kadm_handle, &n_key_data, key_data);
kadm5_free_key_data (kadm_handle, &dummy, key_data);
}
return ret != 0; return ret != 0;
} }