oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

do not dereference NULL pointer modules if we do not have dlopen

Browse Source 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andrew Bartlett
2014-09-03 14:53:36 +12:00
committed by Jeffrey Altman
parent 1c8cae58cc
commit d99b8acd1c
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/krb5/plugin.c
View File

@@ -538,7 +538,7 @@ _krb5_plugin_run_f(krb5_context context,
krb5_error_code (KRB5_LIB_CALL *func)(krb5_context, const void *, void *, void *)) krb5_error_code (KRB5_LIB_CALL *func)(krb5_context, const void *, void *, void *))
{ {
heim_string_t m = heim_string_create(module); heim_string_t m = heim_string_create(module);
heim_dict_t dict; heim_dict_t dict = NULL;
void *plug_ctx; void *plug_ctx;
struct common_plugin_method *cpm; struct common_plugin_method *cpm;
struct iter_ctx s; struct iter_ctx s;
@@ -561,7 +561,9 @@ _krb5_plugin_run_f(krb5_context context,
s.ret = KRB5_PLUGIN_NO_HANDLE; s.ret = KRB5_PLUGIN_NO_HANDLE;
/* Get loaded plugins */ /* Get loaded plugins */
if (modules)
dict = heim_dict_copy_value(modules, m); dict = heim_dict_copy_value(modules, m);
heim_release(m); heim_release(m);
/* Add loaded plugins to s.result array */ /* Add loaded plugins to s.result array */
@@ -603,6 +605,7 @@ _krb5_plugin_run_f(krb5_context context,
heim_release(s.result); heim_release(s.result);
heim_release(s.n); heim_release(s.n);
if (dict)
heim_release(dict); heim_release(dict);
return s.ret; return s.ret;