oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kadmin: Fix return value non-checking in format_field()

Browse Source
This commit is contained in:
Nicolas Williams
2023-01-04 16:22:41 -06:00
parent ad86671923
commit d2bc2a4ce5
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kadmin/get.c
View File

@@ -233,6 +233,8 @@ format_field(struct get_entry_data *data,
size_t buf_len, size_t buf_len,
int condensed) int condensed)
{ {
krb5_error_code ret;
switch(field) { switch(field) {
case KADM5_PRINCIPAL: case KADM5_PRINCIPAL:
if(condensed) if(condensed)
@@ -302,7 +304,10 @@ format_field(struct get_entry_data *data,
krb5_salt def_salt; krb5_salt def_salt;
int i; int i;
char buf2[1024]; char buf2[1024];
krb5_get_pw_salt (context, princ->principal, &def_salt);
ret = krb5_get_pw_salt(context, princ->principal, &def_salt);
if (ret)
krb5_err(context, 1, ret, "krb5_get_pw_salt");
*buf = '\0'; *buf = '\0';
for (i = 0; i < princ->n_key_data; ++i) { for (i = 0; i < princ->n_key_data; ++i) {
@@ -335,7 +340,6 @@ format_field(struct get_entry_data *data,
HDB_EncTypeList etypes; HDB_EncTypeList etypes;
size_t i, size; size_t i, size;
char *str; char *str;
int ret;
ret = decode_HDB_EncTypeList(tl->tl_data_contents, ret = decode_HDB_EncTypeList(tl->tl_data_contents,
tl->tl_data_length, tl->tl_data_length,
@@ -360,7 +364,6 @@ format_field(struct get_entry_data *data,
case KRB5_TL_PKINIT_ACL: { case KRB5_TL_PKINIT_ACL: {
HDB_Ext_PKINIT_acl acl; HDB_Ext_PKINIT_acl acl;
size_t size; size_t size;
int ret;
size_t i; size_t i;
ret = decode_HDB_Ext_PKINIT_acl(tl->tl_data_contents, ret = decode_HDB_Ext_PKINIT_acl(tl->tl_data_contents,
@@ -403,7 +406,6 @@ format_field(struct get_entry_data *data,
case KRB5_TL_ALIASES: { case KRB5_TL_ALIASES: {
HDB_Ext_Aliases alias; HDB_Ext_Aliases alias;
size_t size; size_t size;
int ret;
size_t i; size_t i;
ret = decode_HDB_Ext_Aliases(tl->tl_data_contents, ret = decode_HDB_Ext_Aliases(tl->tl_data_contents,