Merged in REVERSE1-branch.

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@472 ec53bebd-3082-4978-b11e-865c3cabbd6b

appl/kx/Makefile.in

@@ -24,12 +24,13 @@ PROGS = $(PROG_BIN) $(PROG_LIBEXEC)
 
 SOURCES_KX     = kx.c
 SOURCES_KXD    = kxd.c
+SOURCES_COMMON = common.c
 
-OBJECTS_KX     = kx.o
+OBJECTS_KX     = kx.o common.o
-OBJECTS_KXD    = kxd.o
+OBJECTS_KXD    = kxd.o common.o
 
 OBJECTS = $(OBJECTS_KX) $(OBJECTS_KXD)
-SOURCES = $(SOURCES_KX) $(SOURCES_KXD)
+SOURCES = $(SOURCES_KX) $(SOURCES_KXD) $(SOURCES_COMMON)
 
 all: $(PROGS)
 

appl/kx/kx.c

@@ -2,41 +2,37 @@
 
 RCSID("$Id$");
 
-static char *prog;
+char *prog;
 
 static void
 usage()
 {
-  fprintf (stderr, "Usage: %s local-display-number host|display\n",
+     fprintf (stderr, "Usage: %s host\n",
 	      prog);
      exit (1);
 }
 
-static int
-doit_host (char *host, unsigned dnr, int fd)
-{
-  CREDENTIALS cred;
-  KTEXT_ST text;
-  MSG_DAT msg;
-  int status;
-  des_key_schedule schedule;
-  struct sockaddr_in thisaddr, thataddr;
-  int addrlen;
-  void *ret;
-  struct hostent *hostent;
-  int s;
-  struct sockaddr_un unixaddr;
-  des_cblock iv1, iv2;
-  int num1 = 0, num2 = 0;
-
 /*
  * Establish authenticated connection
  */
 
+static int
+connect_host (char *host, des_cblock *key, des_key_schedule schedule)
+{
+     CREDENTIALS cred;
+     KTEXT_ST text;
+     MSG_DAT msg;
+     int status;
+     struct sockaddr_in thisaddr, thataddr;
+     int addrlen;
+     struct hostent *hostent;
+     int s;
+     u_char b;
+
      hostent = gethostbyname (host);
      if (hostent == NULL) {
 	  fprintf (stderr, "%s: gethostbyname '%s' failed: ", prog, host);
-    return 1;
+	  return -1;
      }
 
      memset (&thataddr, 0, sizeof(thataddr));
@@ -47,19 +43,19 @@ doit_host (char *host, unsigned dnr, int fd)
      s = socket (AF_INET, SOCK_STREAM, 0);
      if (s < 0) {
 	  fprintf (stderr, "%s: socket failed: %s\n", prog, k_strerror(errno));
-    return 1;
+	  return -1;
      }
      if (connect (s, (struct sockaddr *)&thataddr, sizeof(thataddr)) < 0) {
 	  fprintf (stderr, "%s: connect(%s) failed: %s\n", prog, host,
 		   k_strerror(errno));
-    return 1;
+	  return -1;
      }
      addrlen = sizeof(thisaddr);
      if (getsockname (s, (struct sockaddr *)&thisaddr, &addrlen) < 0 ||
 	 addrlen != sizeof(thisaddr)) {
 	  fprintf (stderr, "%s: getsockname(%s) failed: %s\n",
 		   prog, host, k_strerror(errno));
-    return 1;
+	  return -1;
      }
      status = krb_sendauth (KOPT_DO_MUTUAL, s, &text, "rcmd",
 			    host, krb_realmofhost (host),
@@ -68,187 +64,164 @@ doit_host (char *host, unsigned dnr, int fd)
      if (status != KSUCCESS) {
 	  fprintf (stderr, "%s: %s: %s\n", prog, host,
 		   krb_get_err_text(status));
-    return 1;
+	  return -1;
-  }
-  /*
-   * Send parameters.
-   */
-
-  {
-    u_char b = dnr;
-    char buf[128];
-    int ret;
-    
-    if (write (s, &b, sizeof(b)) != sizeof(b)) {
-      fprintf (stderr, "%s: write: %s\n", prog, k_strerror (errno));
-      return 1;
      }
      if (read (s, &b, sizeof(b)) != sizeof(b)) {
-      fprintf (stderr, "%s: read: %s\n", prog, k_strerror (errno));
+	  fprintf (stderr, "%s: read: %s\n", prog,
-      return 1;
+		   k_strerror(errno));
+	  return -1;
      }
      if (b) {
-      fprintf (stderr, "%s: Error from '%s': ", prog, host);
-      ret = read (s, buf, sizeof(buf));
-      if(ret < 0) {
-	fprintf (stderr, "%s: read: %s\n", prog, k_strerror (errno));
-	return 1;
-      }
-      fprintf (stderr, "%s\n", buf);
-      return 1;
-    }
-  }
-
-  memcpy (&iv1, &cred.session, sizeof(iv1));
-  memcpy (&iv2, &cred.session, sizeof(iv2));
-  for (;;) {
-    fd_set fdset;
-    int ret;
 	  char buf[BUFSIZ];
 
-    FD_ZERO(&fdset);
+	  read (s, buf, sizeof(buf));
-    FD_SET(s, &fdset);
+	  buf[BUFSIZ - 1] = '\0';
-    FD_SET(fd, &fdset);
 
-    ret = select (256, &fdset, NULL, NULL, NULL); /* XXX */
+	  fprintf (stderr, "%s: %s: %s\n", prog, host, buf);
-    if (ret < 0 && errno != EINTR) {
+	  return -1;
-      fprintf (stderr, "%s: select: %s\n", prog, k_strerror (errno));
+     }
+
+     memcpy(key, &cred.session, sizeof(des_cblock));
+     return s;
+}
+
+static int
+active (int fd, char *host, des_cblock *iv, des_key_schedule schedule)
+{
+     int kxd;
+     u_char zero = 0;
+
+     kxd = connect_host (host, iv, schedule);
+     if (kxd < 0)
+	  return 1;
+     if (write (kxd, &zero, sizeof(zero)) != sizeof(zero)) {
+	  fprintf (stderr, "%s: write: %s\n", prog,
+		   k_strerror(errno));
 	  return 1;
      }
-    if (FD_ISSET(s, &fdset)) {
+     return copy_encrypted (fd, kxd, iv, schedule);
-      ret = read (s, buf, sizeof(buf));
+}
-      if (ret == 0)
+
-	return 0;
+static int
-      if (ret < 0) {
+passive (int fd, char *host, des_cblock *iv, des_key_schedule schedule)
-	fprintf (stderr, "%s: read: %s\n", prog, k_strerror (errno));
+{
+     int xserver;
+
+     xserver = connect_local_xsocket (0);
+     if (xserver < 0)
 	  return 1;
-      }
+     return copy_encrypted (xserver, fd, iv, schedule);
-#ifndef NOENCRYPTION
-      des_cfb64_encrypt (buf, buf, ret, schedule, &iv1,
-			 &num1, DES_DECRYPT);
-#endif
-      ret = krb_net_write (fd, buf, ret);
-      if (ret < 0) {
-	fprintf (stderr, "%s: write: %s\n", prog, k_strerror (errno));
-	return 1;
-      }
-    }
-    if (FD_ISSET(fd, &fdset)) {
-      ret = read (fd, buf, sizeof(buf));
-      if (ret == 0)
-	return 0;
-      if (ret < 0) {
-	fprintf (stderr, "%s: read: %s\n", prog, k_strerror (errno));
-	return 1;
-      }
-#ifndef NOENCRYPTION
-      des_cfb64_encrypt (buf, buf, ret, schedule, &iv2,
-			 &num2, DES_ENCRYPT);
-#endif
-      ret = krb_net_write (s, buf, ret);
-      if (ret < 0) {
-	fprintf (stderr, "%s: write: %s\n", prog, k_strerror (errno));
-	return 1;
-      }
-    }
-  }
 }
 
 /*
- * Listen for calls to the remote X-server.
+ * Connect to the given host.
+ * Iff passivep, give it a port number to call you back and then wait.
+ * Else, listen on a local display and then connect to the remote host
+ * when a local client gets connected.
  */
 
 static int
-doit (unsigned localnr, char *host, unsigned remotenr)
+doit (char *host, int passivep)
 {
-  int fd;
+     int otherside;
-  struct sockaddr_un addr;
+     des_key_schedule schedule;
-  int dnr;
+     des_cblock key;
+     int rendez_vous;
+     int (*fn)(int fd, char *host, des_cblock *iv,
+	       des_key_schedule schedule);
 
-  fd = socket (AF_UNIX, SOCK_STREAM, 0);
+     if (passivep) {
-  if (fd < 0) {
+	  struct sockaddr_in newaddr;
-    fprintf (stderr, "%s: socket failed: %s\n", prog, k_strerror(errno));
+	  int addrlen;
+	  u_char b = passivep;
+	  int otherside;
+
+	  otherside = connect_host (host, &key, schedule);
+	  if (otherside < 0)
 	       return 1;
-  }    
+
-  addr.sun_family = AF_UNIX;
+	  rendez_vous = socket (AF_INET, SOCK_STREAM, 0);
-  sprintf (addr.sun_path, "/tmp/.X11-unix/X%u", localnr);
+	  if (rendez_vous < 0) {
-  unlink (addr.sun_path);
+	       fprintf (stderr, "%s: socket failed: %s\n", prog,
-  if(bind (fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
-    fprintf (stderr, "%s: bind failed: %s\n", prog,
 			k_strerror(errno));
 	       return 1;
 	  }
-  if (listen (fd, 5) < 0) {
+	  memset (&newaddr, 0, sizeof(newaddr));
-    fprintf (stderr, "%s: listen failed: %s\n", prog,
+	  if (bind (rendez_vous, (struct sockaddr *)&newaddr,
+		    sizeof(newaddr)) < 0) {
+	       fprintf (stderr, "%s: bind: %s\n", prog, k_strerror(errno));
+	       return 1;
+	  }
+	  addrlen = sizeof(newaddr);
+	  if (getsockname (rendez_vous, (struct sockaddr *)&newaddr,
+			   &addrlen) < 0) {
+	       fprintf (stderr, "%s: getsockname: %s\n", prog,
 			k_strerror(errno));
 	       return 1;
 	  }
+	  if (listen (rendez_vous, SOMAXCONN) < 0) {
+	       fprintf (stderr, "%s: listen: %s\n", prog, k_strerror(errno));
+	       return 1;
+	  }
+	  if (write (otherside, &b, sizeof(b)) != sizeof(b) ||
+	      write (otherside, &newaddr.sin_port, sizeof(newaddr.sin_port))
+	      != sizeof(newaddr.sin_port)) {
+	       fprintf (stderr, "%s: write: %s\n", prog, k_strerror(errno));
+	       return 1;
+	  }
+	  close (otherside);
+	  fn = passive;
+     } else {
+	  rendez_vous = get_local_xsocket (1); /* XXX */
+	  if (rendez_vous < 0)
+	       return 1;
+	  fn = active;
+     }
      for (;;) {
-    int newfd;
+	  pid_t child;
-    struct sockaddr_un that;
+	  int fd;
-    int len;
+	  int zero = 0;
-    pid_t pid;
 
-    len = sizeof (that);
+	  fd = accept (rendez_vous, NULL, &zero);
-    newfd = accept (fd, (struct sockaddr *)&that, &len);
+	  if (fd < 0)
-    if (newfd < 0)
 	       if (errno == EINTR)
 		    continue;
 	       else {
-	fprintf (stderr, "%s: accept: %s\n", prog, k_strerror (errno));
+		    fprintf (stderr, "%s: accept: %s\n", prog,
+			     k_strerror(errno));
 		    return 1;
 	       }
-    fprintf (stderr, "%s: New connection\n", prog);
+	  child = fork ();
-    pid = fork ();
+	  if (child < 0) {
-    if (pid < 0) {
+	       fprintf (stderr, "%s: fork: %s\n", prog,
-      fprintf (stderr, "%s: fork: %s\n", prog, k_strerror (errno));
+			k_strerror(errno));
-      return 1;
+	       continue;
-    } else if (pid == 0) {
+	  } else if (child == 0) {
-      close (fd);
+	       close (rendez_vous);
-      return doit_host (host, remotenr, newfd);
+	       return (*fn)(fd, host, &key, schedule);
 	  } else {
-      close (newfd);
+	       close (fd);
 	  }
      }
 }
 
-static
-RETSIGTYPE
-childhandler ()
-{
-  pid_t pid;
-  int status;
-
-  do { 
-    pid = waitpid (-1, &status, WNOHANG|WUNTRACED);
-  } while(pid > 0);
-  signal (SIGCHLD, childhandler);
-}
-
 /*
- * fx - forward x connection.
+ * kx - forward x connection over a kerberos-encrypted channel.
+ *
+ * passive mode if $DISPLAY begins with :
  */
 
 int
-main(argc, argv)
+main(int argc, char **argv)
-     int argc;
-     char **argv;
 {
-  int dnr;
+     int passivep;
-  char *p;
+     char *disp;
 
      prog = argv[0];
-  if (argc != 3)
+     if (argc != 2)
 	  usage ();
-
+     disp = getenv("DISPLAY");
-  p = strchr (argv[2], ':');
+     passivep = disp != NULL && *disp == ':';
-  if (p) {
-    *p = '\0';
-    dnr = atoi (p+1);
-  } else
-    dnr = 0;
-
      signal (SIGCHLD, childhandler);
-
+     return doit (argv[1], passivep);
-  return doit (atoi(argv[1]), argv[2], dnr);
 }

appl/kx/kx.h

@@ -24,3 +24,21 @@
 #include <sys/un.h>
 
 #include <krb.h>
+
+#ifndef max
+#define max(a,b) (((a)>(b))?(a):(b))
+#endif
+
+#ifndef SOMAXCONN
+#define SOMAXCONN 5
+#endif
+
+extern char *prog;
+
+int copy_encrypted (int fd1, int fd2, des_cblock *iv,
+		    des_key_schedule schedule);
+
+RETSIGTYPE childhandler ();
+
+int get_local_xsocket (unsigned dnr);
+int connect_local_xsocket (unsigned dnr);

appl/kx/kxd.c

@@ -4,6 +4,8 @@ RCSID("$Id$");
 
 #include <syslog.h>
 
+char *prog;
+
 static int
 fatal (int fd, char *s)
 {
@@ -16,27 +18,19 @@ fatal (int fd, char *s)
 }
 
 static int
-doit(int sock)
+recv_conn (int sock, des_cblock *key, des_key_schedule schedule,
+	   struct sockaddr_in *retaddr)
 {
      int status;
      KTEXT_ST ticket;
      AUTH_DAT auth;
      char instance[INST_SZ + 1];
-     des_key_schedule schedule;
      struct sockaddr_in thisaddr, thataddr;
      int addrlen;
-     int len;
-     char buf[BUFSIZ];
-     void *data;
-     struct passwd *passwd;
      char version[KRB_SENDAUTH_VLEN];
-     int fd;
-     struct stat sb;
-     struct sockaddr_un addr;
      char *username;
-     des_cblock iv1, iv2;
+     u_char ok = 0;
-     int num1 = 0, num2 = 0;
+     struct passwd *passwd;
-     unsigned dnr;
 
      addrlen = sizeof(thisaddr);
      if (getsockname (sock, (struct sockaddr *)&thisaddr, &addrlen) < 0 ||
@@ -57,17 +51,7 @@ doit(int sock)
 	 strncmp(version, "KXSERV.0", KRB_SENDAUTH_VLEN) != 0) {
 	  return 1;
      }
-     {
+     passwd = getpwnam (auth.pname);
-	  u_char b;
-
-	  if (read (sock, &b, sizeof(b)) != sizeof(b))
-	       return 1;
-	  dnr = b;
-     }
-
-     if (stat ("/dev/console", &sb) < 0)
-	  return fatal (sock, "Cannot stat /dev/console");
-     passwd = getpwuid (sb.st_uid);
      if (passwd == NULL)
 	  return fatal (sock, "Cannot find uid");
      username = strdup (passwd->pw_name);
@@ -79,65 +63,103 @@ doit(int sock)
 	 setuid(passwd->pw_uid)) {
 	  return fatal (sock, "Cannot set uid");
      }
-     fd = socket (AF_UNIX, SOCK_STREAM, 0);
+     if (write (sock, &ok, sizeof(ok)) != sizeof(ok))
-     if (fd < 0)
+	  return 1;
-	  return fatal (sock, "Cannot create socket");
+
-     addr.sun_family = AF_UNIX;
+     memcpy(key, &auth.session, sizeof(des_cblock));
-     sprintf (addr.sun_path, "/tmp/.X11-unix/X%u", dnr);
+     *retaddr = thataddr;
-     if (connect (fd, (struct sockaddr *)&addr, sizeof(addr)) < 0)
+     return 0;
+}
+
+static int
+doit_conn (int fd, struct sockaddr_in *thataddr,
+	   des_cblock *key, des_key_schedule schedule)
 {
+  int sock;
+
+  sock = socket (AF_INET, SOCK_STREAM, 0);
+  if (sock < 0) {
     char msg[200];
-	 sprintf (msg, "Cannot connect to %s", addr.sun_path);
+    sprintf (msg, "socket: %s", k_strerror(errno));
     return fatal (sock, msg);
   }
-     memcpy (&iv1, &auth.session, sizeof(iv1));
+  if (connect (sock, (struct sockaddr *)thataddr,
-     memcpy (&iv2, &auth.session, sizeof(iv2));
+	       sizeof(*thataddr)) < 0) {
+    abort ();
+  }
+  return copy_encrypted (fd, sock, key, schedule);
+}
+
+/*
+ *
+ */
+
+static int
+check_user_console ()
 {
-	  u_char b = 0;
+     struct stat sb;
 
-	  if (write (sock, &b, sizeof(b)) != sizeof(b))
+     if (stat ("/dev/console", &sb) < 0)
-	      return 1;
+	  return fatal (0, "Cannot stat /dev/console");
+     if (getuid() != sb.st_uid)
+	  return fatal (0, "Permission denied");
+     return 0;
 }
+
+static int
+doit(int sock)
+{
+     u_char passivep;
+     struct sockaddr_in thataddr;
+     des_key_schedule schedule;
+     des_cblock key;
+     int localx;
+
+     if (recv_conn (sock, &key, schedule, &thataddr))
+	  return 1;
+     if (read (sock, &passivep, sizeof(passivep)) != sizeof(passivep))
+	  return 1;
+     if (passivep) {
+	  if (read (sock, &thataddr.sin_port, sizeof(thataddr.sin_port))
+	      != sizeof(thataddr.sin_port))
+	       return 1;
+	  localx = get_local_xsocket (1);
+	  if (localx < 0)
+	       return 1;
 	  for (;;) {
-	  fd_set fdset;
+	       pid_t child;
-	  int ret;
+	       int fd;
-	  char buf[BUFSIZ];
+	       int zero = 0;
 
-	  FD_ZERO(&fdset);
+	       fd = accept (localx, NULL, &zero);
-	  FD_SET(sock, &fdset);
+	       if (fd < 0)
-	  FD_SET(fd, &fdset);
+		    if (errno == EINTR)
+			 continue;
+		    else {
+			 char msg[200];
+			 sprintf (msg, "accept: %s\n", k_strerror (errno));
+			 return fatal (sock, msg);
+		    }
+	       child = fork ();
+	       if (child < 0) {
+		    char msg[200];
+		    sprintf (msg, "fork: %s\n", k_strerror (errno));
+		    return fatal(sock, msg);
+	       } else if (child == 0) {
+		    close (localx);
+		    return doit_conn (fd, &thataddr, &key, schedule);
+	       } else {
+		    close (fd);
+	       }
+	  }
+     } else {
+	  if (check_user_console ())
+	       return 1;
 
-	  ret = select (fd+1, &fdset, NULL, NULL, NULL);
+	  localx = connect_local_xsocket (0);
-	  if (ret < 0 && errno != EINTR)
+	  if (localx < 0)
 	       return 1;
-	  if (FD_ISSET(sock, &fdset)) {
+	  return copy_encrypted (localx, sock, &key, schedule);
- 	       ret = read (sock, buf, sizeof(buf));
-	       if (ret == 0)
-		    return 0;
-	       if (ret < 0)
-		    return 1;
-#ifndef NOENCRYPTION
-	       des_cfb64_encrypt (buf, buf, ret, schedule,
-				&iv1, &num1, DES_DECRYPT);
-#endif
-	       ret = krb_net_write (fd, buf, ret);
-	       if (ret < 0)
-		    return 1;
-	  }
-	  if (FD_ISSET(fd, &fdset)) {
-	       ret = read (fd, buf, sizeof(buf));
-	       if (ret == 0)
-		    return 0;
-	       if (ret < 0)
-		    return 1;
-#ifndef NOENCRYPTION
-	       des_cfb64_encrypt (buf, buf, ret, schedule,
-				&iv2, &num2, DES_ENCRYPT);
-#endif
-	       ret = krb_net_write (STDOUT_FILENO, buf, ret);
-	       if (ret < 0)
-		    return 1;
-	  }
      }
 }
 
@@ -148,6 +170,9 @@ doit(int sock)
 int
 main (int argc, char **argv)
 {
-     openlog(argv[0], LOG_PID|LOG_CONS, LOG_DAEMON);
+     prog = argv[0];
+
+     openlog(prog, LOG_PID|LOG_CONS, LOG_DAEMON);
+     signal (SIGCHLD, childhandler);
      return doit(0);
 }