oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kcm: Fix coverity issues

Browse Source
This commit is contained in:
Nicolas Williams
2022-01-20 12:38:15 -06:00
parent 7ab7fdd269
commit d1564ce6e9
2 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kcm/cache.c
View File

@@ -168,9 +168,9 @@ krb5_error_code kcm_debug_ccache(krb5_context context)
ncreds++; ncreds++;
if (p->client != NULL) if (p->client != NULL)
krb5_unparse_name(context, p->client, &cpn); (void) krb5_unparse_name(context, p->client, &cpn);
if (p->server != NULL) if (p->server != NULL)
krb5_unparse_name(context, p->server, &spn); (void) krb5_unparse_name(context, p->server, &spn);
kcm_log(7, "cache %08x: name %s refcnt %d flags %04x mode %04o " kcm_log(7, "cache %08x: name %s refcnt %d flags %04x mode %04o "
"uid %d gid %d client %s server %s ncreds %d", "uid %d gid %d client %s server %s ncreds %d",
@@ -179,10 +179,8 @@ krb5_error_code kcm_debug_ccache(krb5_context context)
(spn == NULL) ? "<none>" : spn, (spn == NULL) ? "<none>" : spn,
ncreds); ncreds);
if (cpn != NULL) free(cpn);
free(cpn); free(spn);
if (spn != NULL)
free(spn);
} }
return 0; return 0;

15
kcm/protocol.c
View File

@@ -1747,6 +1747,7 @@ kcm_dispatch(krb5_context context,
krb5_storage *resp_sp = NULL; krb5_storage *resp_sp = NULL;
uint16_t opcode; uint16_t opcode;
krb5_data_zero(resp_data);
resp_sp = krb5_storage_emem(); resp_sp = krb5_storage_emem();
if (resp_sp == NULL) { if (resp_sp == NULL) {
return ENOMEM; return ENOMEM;
@@ -1796,11 +1797,17 @@ out:
krb5_storage_free(req_sp); krb5_storage_free(req_sp);
} }
krb5_storage_seek(resp_sp, 0, SEEK_SET); if (resp_sp) {
krb5_store_int32(resp_sp, ret); krb5_error_code ret2;
ret = krb5_storage_to_data(resp_sp, resp_data); krb5_storage_seek(resp_sp, 0, SEEK_SET);
krb5_storage_free(resp_sp); ret2 = krb5_store_int32(resp_sp, ret);
if (ret2 == 0)
ret2 = krb5_storage_to_data(resp_sp, resp_data);
krb5_storage_free(resp_sp);
if (ret2)
ret = ret2;
}
return ret; return ret;
} }