oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/krb5: load_priv_key do not leak error string

Browse Source 
hx509_get_error_string() returns an allocated string that must
be freed with hx509_free_error_string().

Change-Id: I58d160ce1b09c48b587e8adce74277f6da469ceb
This commit is contained in:
Jeffrey Altman
2022-01-16 17:45:21 -05:00
parent c8956523a1
commit c844a1c62b
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/krb5/kx509.c
View File

@@ -376,10 +376,13 @@ load_priv_key(krb5_context context,
ret = ENOENT; ret = ENOENT;
if (ret == 0) if (ret == 0)
kx509_ctx->priv_key = _hx509_private_key_ref(keys[0]); kx509_ctx->priv_key = _hx509_private_key_ref(keys[0]);
if (ret) if (ret) {
const char *emsg = hx509_get_error_string(context->hx509ctx, ret);
krb5_set_error_message(context, ret, "Could not load private key " krb5_set_error_message(context, ret, "Could not load private key "
"from %s for kx509: %s", fn, "from %s for kx509: %s", fn, emsg);
hx509_get_error_string(context->hx509ctx, ret)); hx509_free_error_string(context->hx509ctx, emsg);
}
hx509_certs_free(&certs); hx509_certs_free(&certs);
return ret; return ret;
} }