oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

krb5: Fix leak in kcm_gen_new()

Browse Source
This commit is contained in:
Nicolas Williams
2022-01-25 15:35:51 -06:00
parent df244493ee
commit a4396ee819
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/krb5/kcm.c
View File

@@ -353,8 +353,7 @@ kcm_free(krb5_context context, krb5_ccache *id)
krb5_kcmcache *k = KCMCACHE(*id); krb5_kcmcache *k = KCMCACHE(*id);
if (k != NULL) { if (k != NULL) {
if (k->name != NULL) free(k->name);
free(k->name);
memset_s(k, sizeof(*k), 0, sizeof(*k)); memset_s(k, sizeof(*k), 0, sizeof(*k));
krb5_data_free(&(*id)->data); krb5_data_free(&(*id)->data);
} }
@@ -446,6 +445,8 @@ kcm_gen_new(krb5_context context, const krb5_cc_ops *ops, krb5_ccache *id)
return ret; return ret;
} }
free(k->name);
k->name = NULL;
ret = krb5_ret_stringz(response, &k->name); ret = krb5_ret_stringz(response, &k->name);
if (ret) if (ret)
ret = KRB5_CC_IO; ret = KRB5_CC_IO;