oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

create_principal() must memset(ent, 0, ...) before ever returning (fixes core dump)

Browse Source
This commit is contained in:
Nicolas Williams
2011-07-18 22:50:59 -05:00
parent cf1c898e95
commit a35ea4955a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/kadm5/create_s.c
View File

@@ -65,6 +65,7 @@ create_principal(kadm5_server_context *context,
kadm5_principal_ent_rec defrec, *defent; kadm5_principal_ent_rec defrec, *defent;
uint32_t def_mask; uint32_t def_mask;
memset(ent, 0, sizeof(*ent));
if((mask & required_mask) != required_mask) if((mask & required_mask) != required_mask)
return KADM5_BAD_MASK; return KADM5_BAD_MASK;
if((mask & forbidden_mask)) if((mask & forbidden_mask))
@@ -72,7 +73,6 @@ create_principal(kadm5_server_context *context,
if((mask & KADM5_POLICY) && strcmp(princ->policy, "default")) if((mask & KADM5_POLICY) && strcmp(princ->policy, "default"))
/* XXX no real policies for now */ /* XXX no real policies for now */
return KADM5_UNK_POLICY; return KADM5_UNK_POLICY;
memset(ent, 0, sizeof(*ent));
ret = krb5_copy_principal(context->context, princ->principal, ret = krb5_copy_principal(context->context, princ->principal,
&ent->entry.principal); &ent->entry.principal);
if(ret) if(ret)