oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Add note about racy tests

Browse Source
This commit is contained in:
Nicolas Williams
2019-06-26 22:55:46 -05:00
parent 859c587dc2
commit a2db5caebf
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/gssapi/krb5/test_kcred.c
View File

@@ -90,7 +90,8 @@ copy_import(void)
if (!equal) if (!equal)
errx(1, "names not equal"); errx(1, "names not equal");
if (lifetime1 != lifetime1) /* FIXME: This check is racy! */
if (lifetime1 != lifetime2)
errx(1, "lifetime not equal"); errx(1, "lifetime not equal");
if (usage1 != usage1) if (usage1 != usage1)

2
lib/gssapi/test_kcred.c
View File

@@ -102,6 +102,7 @@ copy_import(void)
if (!equal) if (!equal)
errx(1, "names not equal"); errx(1, "names not equal");
/* FIXME: This check is racy! */
if (lifetime1 != lifetime2) if (lifetime1 != lifetime2)
errx(1, "lifetime not equal %lu != %lu", errx(1, "lifetime not equal %lu != %lu",
(unsigned long)lifetime1, (unsigned long)lifetime2); (unsigned long)lifetime1, (unsigned long)lifetime2);
@@ -126,6 +127,7 @@ copy_import(void)
if (!equal) if (!equal)
errx(1, "names not equal"); errx(1, "names not equal");
/* FIXME: This check is racy! */
if (lifetime1 != lifetime2) if (lifetime1 != lifetime2)
errx(1, "lifetime not equal %lu != %lu", errx(1, "lifetime not equal %lu != %lu",
(unsigned long)lifetime1, (unsigned long)lifetime2); (unsigned long)lifetime1, (unsigned long)lifetime2);