oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

iprop: Fix coverity warnings

Browse Source
This commit is contained in:
Nicolas Williams
2022-01-19 16:53:45 -06:00
parent 1b213c1082
commit 97cef99f54
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/kadm5/ipropd_master.c
View File

@@ -1435,11 +1435,13 @@ write_master_down(krb5_context context)
fp = fopen(slave_stats_temp_file, "w"); fp = fopen(slave_stats_temp_file, "w");
if (fp == NULL) if (fp == NULL)
return; return;
krb5_format_time(context, t, str, sizeof(str), TRUE); if (krb5_format_time(context, t, str, sizeof(str), TRUE) == 0)
fprintf(fp, "master down at %s\n", str); fprintf(fp, "master down at %s\n", str);
else
fprintf(fp, "master down\n");
if (fclose(fp) != EOF) if (fclose(fp) != EOF)
rk_rename(slave_stats_temp_file, slave_stats_file); (void) rk_rename(slave_stats_temp_file, slave_stats_file);
} }
static void static void
@@ -1455,7 +1457,8 @@ write_stats(krb5_context context, slave *slaves, uint32_t current_version)
if (fp == NULL) if (fp == NULL)
return; return;
krb5_format_time(context, t, str, sizeof(str), TRUE); if (krb5_format_time(context, t, str, sizeof(str), TRUE))
snprintf(str, sizeof(str), "<unknown-time>");
fprintf(fp, "Status for slaves, last updated: %s\n\n", str); fprintf(fp, "Status for slaves, last updated: %s\n\n", str);
fprintf(fp, "Master version: %lu\n\n", (unsigned long)current_version); fprintf(fp, "Master version: %lu\n\n", (unsigned long)current_version);
@@ -1509,7 +1512,7 @@ write_stats(krb5_context context, slave *slaves, uint32_t current_version)
rtbl_destroy(tbl); rtbl_destroy(tbl);
if (fclose(fp) != EOF) if (fclose(fp) != EOF)
rk_rename(slave_stats_temp_file, slave_stats_file); (void) rk_rename(slave_stats_temp_file, slave_stats_file);
} }

2
lib/kadm5/ipropd_slave.c
View File

@@ -184,6 +184,8 @@ ihave(krb5_context context, krb5_auth_context auth_context,
krb5_data data; krb5_data data;
sp = krb5_storage_from_mem(buf, 8); sp = krb5_storage_from_mem(buf, 8);
if (sp == NULL)
krb5_err(context, IPROPD_RESTART_SLOW, ENOMEM, "Out of memory");
ret = krb5_store_uint32(sp, I_HAVE); ret = krb5_store_uint32(sp, I_HAVE);
if (ret == 0) if (ret == 0)
ret = krb5_store_uint32(sp, version); ret = krb5_store_uint32(sp, version);