oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/krb5: fcc_remove_cred return krb5_cc_end_seq_get failure

Browse Source 
krb5_cc_end_seq_get() is not expected to fail because it is a
cleanup routine.  If it fails it indicates something wrong with
the cache or the system.  Return the failure if there is one.

Otherwise, the failure from krb5_cc_next_cred() should be
returned UNLESS it is KRB5_CC_END in which case return success.

Change-Id: I80e07103e2fb38aa40418a436fa5351fb89549d3
This commit is contained in:
Jeffrey Altman
2022-01-20 10:06:11 -05:00
parent 29940dd22c
commit 966e98d50b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/krb5/fcache.c
View File

@@ -1176,7 +1176,7 @@ fcc_remove_cred(krb5_context context,
krb5_free_cred_contents(context, &found_cred); krb5_free_cred_contents(context, &found_cred);
} }
ret2 = krb5_cc_end_seq_get(context, id, &cursor); ret2 = krb5_cc_end_seq_get(context, id, &cursor);
if (ret == 0) if (ret2) /* not expected to fail */
return ret2; return ret2;
if (ret == KRB5_CC_END) if (ret == KRB5_CC_END)
return 0; return 0;