oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

(check_compat): avoid leaking principal when finding a match

Browse Source 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12579 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Love Hörnquist Åstrand
2003-08-17 19:01:42 +00:00
parent d84816fed2
commit 8eb2b0ceea
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/gssapi/compat.c
View File

@@ -51,8 +51,8 @@ check_compat(OM_uint32 *minor_status, gss_name_t name,
if(p == NULL) if(p == NULL)
return 0; return 0;
match = NULL;
for(q = p; *q; q++) { for(q = p; *q; q++) {
ret = krb5_parse_name(gssapi_krb5_context, *q, &match); ret = krb5_parse_name(gssapi_krb5_context, *q, &match);
if (ret) if (ret)
break; break;
@@ -63,7 +63,10 @@ check_compat(OM_uint32 *minor_status, gss_name_t name,
} }
krb5_free_principal(gssapi_krb5_context, match); krb5_free_principal(gssapi_krb5_context, match);
match = NULL;
} }
if (match)
krb5_free_principal(gssapi_krb5_context, match);
krb5_config_free_strings(p); krb5_config_free_strings(p);
if (ret) { if (ret) {

5
lib/gssapi/krb5/compat.c
View File

@@ -51,8 +51,8 @@ check_compat(OM_uint32 *minor_status, gss_name_t name,
if(p == NULL) if(p == NULL)
return 0; return 0;
match = NULL;
for(q = p; *q; q++) { for(q = p; *q; q++) {
ret = krb5_parse_name(gssapi_krb5_context, *q, &match); ret = krb5_parse_name(gssapi_krb5_context, *q, &match);
if (ret) if (ret)
break; break;
@@ -63,7 +63,10 @@ check_compat(OM_uint32 *minor_status, gss_name_t name,
} }
krb5_free_principal(gssapi_krb5_context, match); krb5_free_principal(gssapi_krb5_context, match);
match = NULL;
} }
if (match)
krb5_free_principal(gssapi_krb5_context, match);
krb5_config_free_strings(p); krb5_config_free_strings(p);
if (ret) { if (ret) {