oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

_gss_ntlm_init_sec_context() mem leaks

Browse Source
This commit is contained in:
Roland C. Dowdeswell
2021-09-05 22:32:12 +01:00
committed by Jeffrey Altman
parent e87fca8091
commit 8dcd05ed4d
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/gssapi/ntlm/init_sec_context.c
View File

@@ -381,6 +381,7 @@ _gss_ntlm_init_sec_context
if (RAND_bytes(nonce, sizeof(nonce)) != 1) { if (RAND_bytes(nonce, sizeof(nonce)) != 1) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = EINVAL; *minor_status = EINVAL;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -399,6 +400,7 @@ _gss_ntlm_init_sec_context
} }
if (ret) { if (ret) {
_gss_ntlm_delete_sec_context(minor_status,context_handle,NULL); _gss_ntlm_delete_sec_context(minor_status,context_handle,NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -413,6 +415,7 @@ _gss_ntlm_init_sec_context
if (type3.ntlm.data) if (type3.ntlm.data)
free(type3.ntlm.data); free(type3.ntlm.data);
_gss_ntlm_delete_sec_context(minor_status,context_handle,NULL); _gss_ntlm_delete_sec_context(minor_status,context_handle,NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -426,6 +429,7 @@ _gss_ntlm_init_sec_context
if (type3.ntlm.data) if (type3.ntlm.data)
free(type3.ntlm.data); free(type3.ntlm.data);
_gss_ntlm_delete_sec_context(minor_status,context_handle,NULL); _gss_ntlm_delete_sec_context(minor_status,context_handle,NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -442,6 +446,7 @@ _gss_ntlm_init_sec_context
if(ret) { if(ret) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_DEFECTIVE_TOKEN; return GSS_S_DEFECTIVE_TOKEN;
} }
@@ -449,6 +454,7 @@ _gss_ntlm_init_sec_context
if (ti.domainname && strcmp(ti.domainname, name->domain) != 0) { if (ti.domainname && strcmp(ti.domainname, name->domain) != 0) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = EINVAL; *minor_status = EINVAL;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -464,6 +470,7 @@ _gss_ntlm_init_sec_context
if (ret) { if (ret) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -475,6 +482,7 @@ _gss_ntlm_init_sec_context
if (ret) { if (ret) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -487,6 +495,7 @@ _gss_ntlm_init_sec_context
if (ret) { if (ret) {
_gss_ntlm_delete_sec_context(minor_status, _gss_ntlm_delete_sec_context(minor_status,
context_handle, NULL); context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -504,6 +513,7 @@ _gss_ntlm_init_sec_context
free(type3.ntlm.data); free(type3.ntlm.data);
if (ret) { if (ret) {
_gss_ntlm_delete_sec_context(minor_status, context_handle, NULL); _gss_ntlm_delete_sec_context(minor_status, context_handle, NULL);
heim_ntlm_free_type2(&type2);
*minor_status = ret; *minor_status = ret;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
@@ -520,6 +530,7 @@ _gss_ntlm_init_sec_context
ctx->status |= STATUS_OPEN; ctx->status |= STATUS_OPEN;
heim_ntlm_free_type2(&type2);
return GSS_S_COMPLETE; return GSS_S_COMPLETE;
} }
} }