oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hx509: Fix harmless TOCTOU in load_crl()

Browse Source
This commit is contained in:
Nicolas Williams
2023-01-03 20:41:45 -06:00
parent 64254d64dd
commit 8b44896bc1
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/hx509/revoke.c
View File

@@ -600,18 +600,15 @@ load_crl(hx509_context context, const char *path, time_t *t, CRLCertificateList
FILE *f; FILE *f;
int ret; int ret;
*t = 0;
memset(crl, 0, sizeof(*crl)); memset(crl, 0, sizeof(*crl));
ret = stat(path, &sb);
if (ret)
return errno;
*t = sb.st_mtime;
if ((f = fopen(path, "r")) == NULL) if ((f = fopen(path, "r")) == NULL)
return errno; return errno;
rk_cloexec_file(f); rk_cloexec_file(f);
if (fstat(fileno(f), &sb) == 0)
*t = sb.st_mtime;
ret = hx509_pem_read(context, f, crl_parser, crl); ret = hx509_pem_read(context, f, crl_parser, crl);
fclose(f); fclose(f);