oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

asn1: Improve XXX comment

Browse Source
This commit is contained in:
Nicolas Williams
2021-02-08 22:40:39 -06:00
parent dbb8882971
commit 89f97e8287
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/asn1/gen_template.c
View File

@@ -70,7 +70,13 @@ static const char *
integer_symbol(const char *basename, const Type *t) integer_symbol(const char *basename, const Type *t)
{ {
if (t->members) if (t->members)
return "int"; /* XXX enum foo */ /*
* XXX enum foo -- compute the size either from inspecting the members
* and applying the ABI's rules for enum size, OR infer the field
* size from a template by using the offsetof field. The latter is
* hard to do though.
*/
return "int";
else if (t->range == NULL) else if (t->range == NULL)
return "heim_integer"; return "heim_integer";
else if (t->range->min < INT_MIN && t->range->max <= INT64_MAX) else if (t->range->min < INT_MIN && t->range->max <= INT64_MAX)