oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Double free of sp on empty list of creds [CID-183]

Browse Source
This commit is contained in:
Love Hornquist Astrand
2009-07-30 07:46:37 +02:00
parent 1ca716bbc7
commit 896391a56b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/gssapi/mech/gss_cred.c
View File

@@ -115,7 +115,7 @@ gss_import_cred(OM_uint32 * minor_status,
gssapi_mech_interface m; gssapi_mech_interface m;
krb5_error_code ret; krb5_error_code ret;
struct _gss_cred *cred; struct _gss_cred *cred;
krb5_storage *sp; krb5_storage *sp = NULL;
OM_uint32 major, junk; OM_uint32 major, junk;
krb5_data data; krb5_data data;
@@ -204,6 +204,7 @@ gss_import_cred(OM_uint32 * minor_status,
SLIST_INSERT_HEAD(&cred->gc_mc, mc, gmc_link); SLIST_INSERT_HEAD(&cred->gc_mc, mc, gmc_link);
} }
krb5_storage_free(sp); krb5_storage_free(sp);
sp = NULL;
if (SLIST_EMPTY(&cred->gc_mc)) { if (SLIST_EMPTY(&cred->gc_mc)) {
major = GSS_S_NO_CRED; major = GSS_S_NO_CRED;
@@ -213,7 +214,8 @@ gss_import_cred(OM_uint32 * minor_status,
return GSS_S_COMPLETE; return GSS_S_COMPLETE;
out: out:
krb5_storage_free(sp); if (sp)
krb5_storage_free(sp);
gss_release_cred(&junk, cred_handle); gss_release_cred(&junk, cred_handle);