oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kpasswd: check krb5_unparse_name return

Browse Source 
In verify() if krb5_unparse_name() fails 'sname' will be used
unitialized in the subsequent krb5_warnx() and free() calls.

Change-Id: I5a49bf06879eb5a77cf2d1d3f0d4b9c6549aeff8
This commit is contained in:
Jeffrey Altman
2016-04-17 15:17:30 -05:00
parent 4ad2f5830a
commit 87d56ef018
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kpasswd/kpasswdd.c
View File

@@ -530,8 +530,10 @@ verify (krb5_auth_context *auth_context,
if (!same) {
char *sname;
krb5_unparse_name(context, (*ticket)->server, &sname);
krb5_warnx(context, "Invalid kpasswd service principal %s", sname);
if (krb5_unparse_name(context, (*ticket)->server, &sname) != 0)
sname = NULL;
krb5_warnx(context, "Invalid kpasswd service principal %s",
sname ? sname : "<enomem>");
free(sname);
reply_error(NULL, s, sa, sa_size, ret, 1, "Bad request");
goto out;