oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

fix memory leak near NTLM type2 response

Browse Source
This commit is contained in:
Roland C. Dowdeswell
2021-09-05 21:44:44 +01:00
committed by Jeffrey Altman
parent d64076dfd9
commit 8526b4c627
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/gssapi/ntlm/accept_sec_context.c
View File

@@ -171,12 +171,14 @@ _gss_ntlm_accept_sec_context
output_token->value = malloc(out.length); output_token->value = malloc(out.length);
if (output_token->value == NULL && out.length != 0) { if (output_token->value == NULL && out.length != 0) {
OM_uint32 gunk; OM_uint32 gunk;
heim_ntlm_free_buf(&out);
_gss_ntlm_delete_sec_context(&gunk, context_handle, NULL); _gss_ntlm_delete_sec_context(&gunk, context_handle, NULL);
*minor_status = ENOMEM; *minor_status = ENOMEM;
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
memcpy(output_token->value, out.data, out.length); memcpy(output_token->value, out.data, out.length);
output_token->length = out.length; output_token->length = out.length;
heim_ntlm_free_buf(&out);
ctx->flags = retflags; ctx->flags = retflags;

1
lib/gssapi/ntlm/kdc.c
View File

@@ -252,6 +252,7 @@ kdc_type2(OM_uint32 *minor_status,
krb5_data ti; krb5_data ti;
memset(&type2, 0, sizeof(type2)); memset(&type2, 0, sizeof(type2));
memset(out, 0, sizeof(*out));
/* /*
* Request data for type 2 packet from the KDC. * Request data for type 2 packet from the KDC.