oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Check return values from setuid, prompted by MIT

Browse Source 
advisory.  Thanks to Tom Yu at MIT, and Michael Calmer and Marcus
Meissner at SUSE.  Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17878 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Love Hörnquist Åstrand
2006-08-08 21:43:58 +00:00
parent cd67e721c3
commit 847a99a0ec
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
appl/rcp/rcp.c
View File

@@ -119,13 +119,15 @@ main(int argc, char **argv)
if (fflag) { /* Follow "protocol", send data. */ if (fflag) { /* Follow "protocol", send data. */
response(); response();
setuid(userid); if (setuid(userid) < 0)
errx(1, "setuid failed");
source(argc, argv); source(argc, argv);
exit(errs); exit(errs);
} }
if (tflag) { /* Receive data. */ if (tflag) { /* Receive data. */
setuid(userid); if (setuid(userid) < 0)
errx(1, "setuid failed");
sink(argc, argv); sink(argc, argv);
exit(errs); exit(errs);
} }
@@ -221,7 +223,8 @@ toremote(char *targ, int argc, char **argv)
if (response() < 0) if (response() < 0)
exit(1); exit(1);
free(bp); free(bp);
setuid(userid); if (setuid(userid) < 0)
errx(1, "setuid failed");
} }
source(1, argv+i); source(1, argv+i);
} }

3
appl/rcp/util.c
View File

@@ -112,7 +112,8 @@ susystem(s, userid)
return (127); return (127);
case 0: case 0:
(void)setuid(userid); if (setuid(userid) < 0)
_exit(127);
execl(_PATH_BSHELL, "sh", "-c", s, NULL); execl(_PATH_BSHELL, "sh", "-c", s, NULL);
_exit(127); _exit(127);
} }