oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

roken: getaddrinfo get_null return errors

Browse Source 
get_null() can fail for two reasons.  There can be a memory allocation
issue or the hints->ai_family could be unsupported.  This change
informs the caller of the error state instead of returning success
with an invalid struct addrinfo output parameter.

Fixes #1007
Reported-by: opless
This commit is contained in:
Jeffrey Altman
2022-09-16 13:48:55 -04:00
parent 76c110e1ef
commit 7b914bfb64
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/roken/getaddrinfo.c
View File

@@ -188,7 +188,7 @@ get_null (const struct addrinfo *hints,
struct addrinfo *first = NULL; struct addrinfo *first = NULL;
struct addrinfo **current = &first; struct addrinfo **current = &first;
int family = PF_UNSPEC; int family = PF_UNSPEC;
int ret; int ret = EAI_FAMILY;
if (hints != NULL) if (hints != NULL)
family = hints->ai_family; family = hints->ai_family;
@@ -216,7 +216,7 @@ get_null (const struct addrinfo *hints,
&current, const_v4, &v4_addr, NULL); &current, const_v4, &v4_addr, NULL);
} }
*res = first; *res = first;
return 0; return ret;
} }
static int static int