oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

(hdb_free_entry): zero keys

Browse Source 
(hdb_check_db_format): leak less memory


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3217 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Assar Westerlund
1997-08-28 01:27:30 +00:00
parent dff048a48d
commit 779887b43e
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/hdb/hdb.c
View File

@@ -232,6 +232,13 @@ hdb_unlock(int fd)
void void
hdb_free_entry(krb5_context context, hdb_entry *ent) hdb_free_entry(krb5_context context, hdb_entry *ent)
{ {
int i;
for(i = 0; i < ent->keys.len; ++i) {
Key *k = &ent->keys.val[i];
memset (k->key.keyvalue.data, 0, k->key.keyvalue.length);
}
free_hdb_entry(ent); free_hdb_entry(ent);
} }
@@ -262,12 +269,16 @@ hdb_check_db_format(krb5_context context, HDB *db)
krb5_data version; krb5_data version;
krb5_error_code ret; krb5_error_code ret;
unsigned ver; unsigned ver;
int foo;
tag.data = HDB_DB_FORMAT_ENTRY; tag.data = HDB_DB_FORMAT_ENTRY;
tag.length = strlen(tag.data); tag.length = strlen(tag.data);
ret = (*db->_get)(context, db, tag, &version); ret = (*db->_get)(context, db, tag, &version);
if(ret) if(ret)
return ret; return ret;
if(sscanf(version.data, "%u", &ver) != 1) foo = sscanf(version.data, "%u", &ver);
krb5_data_free (&version);
if (foo != 1)
return HDB_ERR_BADVERSION; return HDB_ERR_BADVERSION;
if(ver != HDB_DB_FORMAT) if(ver != HDB_DB_FORMAT)
return HDB_ERR_BADVERSION; return HDB_ERR_BADVERSION;