oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/hdb: entry2mit_string_int free unparsed name on error

Browse Source 
if append_string() fails do not leak the unparsed name.

Change-Id: I29d909c35e0e5d7282577ce37ec283efc33edbbf
This commit is contained in:
Jeffrey Altman
2022-01-16 22:19:39 -05:00
parent b63da31622
commit 73e2f335c2
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/hdb/print.c
View File

@@ -475,12 +475,16 @@ entry2mit_string_int(krb5_context context, krb5_storage *sp, hdb_entry *ent)
d.data = &val; d.data = &val;
d.length = sizeof (ent->modified_by->time); d.length = sizeof (ent->modified_by->time);
ret = krb5_unparse_name(context, ent->modified_by->principal, &modby_p); ret = krb5_unparse_name(context, ent->modified_by->principal, &modby_p);
if (ret) return ret; if (ret)
return ret;
plen = strlen(modby_p); plen = strlen(modby_p);
sz = append_string(context, sp, "\t%u\t%u\t", sz = append_string(context, sp, "\t%u\t%u\t",
mit_KRB5_TL_MOD_PRINC, mit_KRB5_TL_MOD_PRINC,
d.length + plen + 1 /* NULL counted */); d.length + plen + 1 /* NULL counted */);
if (sz == -1) return ENOMEM; if (sz == -1) {
free(modby_p);
return ENOMEM;
}
sz = append_hex(context, sp, 1, 1, &d); sz = append_hex(context, sp, 1, 1, &d);
if (sz == -1) { if (sz == -1) {
free(modby_p); free(modby_p);
@@ -490,7 +494,8 @@ entry2mit_string_int(krb5_context context, krb5_storage *sp, hdb_entry *ent)
d.length = plen + 1; d.length = plen + 1;
sz = append_hex(context, sp, 1, 1, &d); sz = append_hex(context, sp, 1, 1, &d);
free(modby_p); free(modby_p);
if (sz == -1) return ENOMEM; if (sz == -1)
return ENOMEM;
} }
/* /*
* Dump keys (remembering to not include any with kvno higher than * Dump keys (remembering to not include any with kvno higher than