oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hx509_request_get_san can return an output string on failure

Browse Source 
Tighten up all of the call sites of hx509_request_get_san()
to free the output string returned upon failure.

Use frees(&s) instead of free(s); s = NULL;.

Change-Id: I71035d7c1d2330a1a3a1b3b730cdd6ba1e6b7da3
This commit is contained in:
Jeffrey Altman
2022-01-16 21:36:09 -05:00
parent 3065730b8a
commit 708d9b4042
3 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kdc/simple_csr_authorizer.c
View File

@@ -157,6 +157,13 @@ string_encode(const char *in)
return s;
}
static void
frees(char **s)
{
free(*s);
*s = NULL;
}
static KRB5_LIB_CALL krb5_error_code
authorize(void *ctx,
krb5_context context,
@@ -235,12 +242,12 @@ authorize(void *ctx,
ret = stat(p, &st) == -1 ? errno : 0;
free(san);
free(p);
free(s);
s = NULL;
frees(&s);
if (ret)
goto skip;
ret = hx509_request_authorize_san(csr, i);
}
frees(&s);
if (ret == HX509_NO_ITEM)
ret = 0;
if (ret)
@@ -257,8 +264,7 @@ authorize(void *ctx,
goto enomem;
ret = stat(p, &st) == -1 ? errno : 0;
free(p);
free(s);
s = NULL;
frees(&s);
if (ret)
goto skip;
ret = hx509_request_authorize_eku(csr, i);