oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Validate plug-in names before loading

Browse Source 
On Windows, we only want to load .dll files are plug-ins, even though
there might be other support files present in the plug-in directory.
This commit is contained in:
Asanka C. Herath
2010-09-21 17:33:05 -04:00
parent 7fea5ff69a
commit 6abe08a0a3
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/krb5/plugin.c
View File

@@ -179,6 +179,28 @@ krb5_plugin_register(krb5_context context,
return 0;
}
static int
is_valid_plugin_filename(const char * n)
{
if (n[0] == '.' && (n[1] == '\0' || (n[1] == '.' && n[2] == '\0')))
return 0;
#ifdef _WIN32
/* On Windows, we only attempt to load .dll files as plug-ins. */
{
const char * ext;
ext = strrchr(n, '.');
if (ext == NULL)
return 0;
return !stricmp(ext, ".dll");
}
#endif
return 1;
}
static krb5_error_code
load_plugins(krb5_context context)
{
@@ -219,7 +241,7 @@ load_plugins(krb5_context context)
char *n = entry->d_name;
/* skip . and .. */
if (n[0] == '.' && (n[1] == '\0' || (n[1] == '.' && n[2] == '\0')))
if (!is_valid_plugin_filename(n))
continue;
path = NULL;