oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

roken/parse_bytes: fix test for >= terabyte units on 32 bit systems

Browse Source 
On 32 bit systems, sizeof(ssize_t) and sizeof(unsigned long aka UL) is
32 bits which is not able to hold the value of a terabyte.
This commit is contained in:
Robert Manner
2022-11-08 14:47:40 +01:00
committed by Nico Williams
parent 997916e3f6
commit 65e5b0ab79
4 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/roken/parse_bytes-test.c
View File

@@ -38,7 +38,7 @@
static struct testcase {
int canonicalp;
ssize_t val;
int64_t val;
const char *def_unit;
const char *str;
} tests[] = {
@@ -52,7 +52,7 @@ static struct testcase {
{1, 1024 * 1024, NULL, "1 megabyte"},
{0, 1025, NULL, "1 kilobyte 1"},
{1, 1025, NULL, "1 kilobyte 1 byte"},
{1, 1024UL * 1024 * 1024 * 1024, NULL, "1 terabyte"},
{1, 1024ULL * 1024 * 1024 * 1024, NULL, "1 terabyte"},
};
int
@@ -63,7 +63,7 @@ main(int argc, char **argv)
for (i = 0; i < sizeof(tests)/sizeof(tests[0]); ++i) {
char buf[256];
ssize_t val = parse_bytes (tests[i].str, tests[i].def_unit);
int64_t val = parse_bytes (tests[i].str, tests[i].def_unit);
if (val != tests[i].val) {
printf ("parse_bytes (%s, %s) = %lld != %lld\n",