Fix warnings (some bugs, some spurious)

Many spurious VC warnings not quieted though.
2020-03-12 00:42:33 -05:00
parent f3e6c4ffd4
commit 64d5f86ec3
20 changed files with 38 additions and 36 deletions
--- a/lib/hx509/ks_file.c
+++ b/lib/hx509/ks_file.c
@@ -619,7 +619,7 @@ mk_temp(const char *fn, char **tfn)
        return -1;
    }

-    if (p = strrchr(ds, '\\') == NULL) {
+    if ((p = strrchr(ds, '\\')) == NULL) {
        ret = asprintf(tfn, ".%s-XXXXXX", ds); /* XXX can't happen */
    } else {
        *(p++) = '\0';