Use roken_get_*() instead of getpwuuid()
Using non-reentrant getpwuid() (or getpwnam(), or getspnam()) can be dangerous. We had a report of a login application / PAM that calls those, and Heimdal, by calling them too, clobbered the cached struct passwd used by the login app / PAM.
This commit is contained in:

committed by
Nico Williams

parent
95eb83c424
commit
620862049e
@@ -84,7 +84,7 @@ $(OBJ)\kadmin-commands.c $(OBJ)\kadmin-commands.h: kadmin-commands.in
|
||||
cd $(SRCDIR)
|
||||
|
||||
$(SBINDIR)\kadmin.exe: $(KADMIN_OBJS) $(KADMIN_LIBS)
|
||||
$(EXECONLINK)
|
||||
$(EXECONLINK) Secur32.lib Shell32.lib
|
||||
$(EXEPREP)
|
||||
|
||||
KADMIND_OBJS= \
|
||||
@@ -100,7 +100,7 @@ KADMIND_LIBS=\
|
||||
$(COMMON_LIBS)
|
||||
|
||||
$(LIBEXECDIR)\kadmind.exe: $(KADMIND_OBJS) $(KADMIND_LIBS)
|
||||
$(EXECONLINK)
|
||||
$(EXECONLINK) Secur32.lib Shell32.lib
|
||||
$(EXEPREP)
|
||||
|
||||
all:: $(INCFILES) $(SBIN_PROGRAMS) $(LIBEXEC_PROGRAMS)
|
||||
@@ -115,13 +115,13 @@ clean::
|
||||
NOINST_PROGRAMS=$(OBJ)\add_random_users.exe
|
||||
|
||||
$(OBJ)\add_random_users.exe: $(OBJ)\add_random_users.obj $(LIBKADM5SRV) $(LIBKADM5CLNT) $(COMMON_LIBS)
|
||||
$(EXECONLINK)
|
||||
$(EXECONLINK) Secur32.lib Shell32.lib
|
||||
$(EXEPREP_NODIST)
|
||||
|
||||
TEST_BINARIES=$(OBJ)\test_util.exe
|
||||
|
||||
$(OBJ)\test_util.exe: $(OBJ)\test_util.obj $(OBJ)\util.obj $(KADMIN_LIBS)
|
||||
$(EXECONLINK)
|
||||
$(EXECONLINK) Secur32.lib Shell32.lib
|
||||
$(EXEPREP_NODIST)
|
||||
|
||||
test-binaries: $(TEST_BINARIES)
|
||||
|
Reference in New Issue
Block a user