Use mkstemp.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1767 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
		@@ -41,8 +41,7 @@ pop_dropcopy(POP *p, struct passwd *pwp)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
    /* First create a unique file.  Would prefer mkstemp, but Ultrix...*/
 | 
					    /* First create a unique file.  Would prefer mkstemp, but Ultrix...*/
 | 
				
			||||||
    strcpy(template,POP_TMPDROP);
 | 
					    strcpy(template,POP_TMPDROP);
 | 
				
			||||||
    mktemp(template);
 | 
					    if ((tf=fdopen(mkstemp(template),"w+")) == NULL) {	/* failure, bail out */
 | 
				
			||||||
    if ( (tf=fopen(template,"w+")) == NULL ) {	/* failure, bail out	*/
 | 
					 | 
				
			||||||
        pop_log(p,POP_PRIORITY,
 | 
					        pop_log(p,POP_PRIORITY,
 | 
				
			||||||
            "Unable to create temporary temporary maildrop '%s': %s",template,
 | 
					            "Unable to create temporary temporary maildrop '%s': %s",template,
 | 
				
			||||||
		strerror(errno));
 | 
							strerror(errno));
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -24,18 +24,17 @@ pop_xmit (POP *p)
 | 
				
			|||||||
    int                     id, pid;
 | 
					    int                     id, pid;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    /*  Create a temporary file into which to copy the user's message */
 | 
					    /*  Create a temporary file into which to copy the user's message */
 | 
				
			||||||
    mktemp(strcpy(temp_xmit,POP_TMPXMIT));
 | 
					    if ((tmp = fdopen(mkstemp(temp_xmit), "w+")) == NULL)
 | 
				
			||||||
#ifdef DEBUG
 | 
					 | 
				
			||||||
    if(p->debug)
 | 
					 | 
				
			||||||
        pop_log(p, POP_DEBUG,
 | 
					 | 
				
			||||||
            "Creating temporary file for sending a mail message \"%s\"\n",
 | 
					 | 
				
			||||||
                temp_xmit);
 | 
					 | 
				
			||||||
#endif /* DEBUG */
 | 
					 | 
				
			||||||
    if ((tmp = fopen(temp_xmit, "w+")) == NULL)
 | 
					 | 
				
			||||||
        return (pop_msg(p, POP_FAILURE,
 | 
					        return (pop_msg(p, POP_FAILURE,
 | 
				
			||||||
			"Unable to create temporary message file \"%s\": %s",
 | 
								"Unable to create temporary message file \"%s\": %s",
 | 
				
			||||||
			temp_xmit,
 | 
								temp_xmit,
 | 
				
			||||||
			strerror(errno)));
 | 
								strerror(errno)));
 | 
				
			||||||
 | 
					#ifdef DEBUG
 | 
				
			||||||
 | 
					    if(p->debug)
 | 
				
			||||||
 | 
					        pop_log(p, POP_DEBUG,
 | 
				
			||||||
 | 
							"Creating temporary file for sending a mail message \"%s\"\n",
 | 
				
			||||||
 | 
					                temp_xmit);
 | 
				
			||||||
 | 
					#endif /* DEBUG */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    /*  Tell the client to start sending the message */
 | 
					    /*  Tell the client to start sending the message */
 | 
				
			||||||
    pop_msg(p,POP_SUCCESS,"Start sending the message.");
 | 
					    pop_msg(p,POP_SUCCESS,"Start sending the message.");
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user